* [Qemu-devel] [PATCH for-2.0] iscsi: recognize "invalid field" ASCQ from WRITE SAME command
@ 2014-04-02 12:45 Paolo Bonzini
2014-04-02 20:32 ` Peter Lieven
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2014-04-02 12:45 UTC (permalink / raw)
To: qemu-devel; +Cc: pl
Some targets may return "invalid field" as the ASCQ from WRITE SAME
if they support the command only without the UNMAP field. Recognize
that, and return ENOTSUP just like for "invalid operation code".
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
block/iscsi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index 6d6cd4f..f01c883 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -1012,7 +1012,8 @@ retry:
if (iTask.status == SCSI_STATUS_CHECK_CONDITION &&
iTask.task->sense.key == SCSI_SENSE_ILLEGAL_REQUEST &&
- iTask.task->sense.ascq == SCSI_SENSE_ASCQ_INVALID_OPERATION_CODE) {
+ (iTask.task->sense.ascq == SCSI_SENSE_ASCQ_INVALID_OPERATION_CODE ||
+ iTask.task->sense.ascq == SCSI_SENSE_ASCQ_INVALID_FIELD_IN_CDB)) {
/* WRITE SAME is not supported by the target */
iscsilun->has_write_same = false;
scsi_free_scsi_task(iTask.task);
--
1.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH for-2.0] iscsi: recognize "invalid field" ASCQ from WRITE SAME command
2014-04-02 12:45 [Qemu-devel] [PATCH for-2.0] iscsi: recognize "invalid field" ASCQ from WRITE SAME command Paolo Bonzini
@ 2014-04-02 20:32 ` Peter Lieven
0 siblings, 0 replies; 2+ messages in thread
From: Peter Lieven @ 2014-04-02 20:32 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel
Am 02.04.2014 14:45, schrieb Paolo Bonzini:
> Some targets may return "invalid field" as the ASCQ from WRITE SAME
> if they support the command only without the UNMAP field. Recognize
> that, and return ENOTSUP just like for "invalid operation code".
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> block/iscsi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/block/iscsi.c b/block/iscsi.c
> index 6d6cd4f..f01c883 100644
> --- a/block/iscsi.c
> +++ b/block/iscsi.c
> @@ -1012,7 +1012,8 @@ retry:
>
> if (iTask.status == SCSI_STATUS_CHECK_CONDITION &&
> iTask.task->sense.key == SCSI_SENSE_ILLEGAL_REQUEST &&
> - iTask.task->sense.ascq == SCSI_SENSE_ASCQ_INVALID_OPERATION_CODE) {
> + (iTask.task->sense.ascq == SCSI_SENSE_ASCQ_INVALID_OPERATION_CODE ||
> + iTask.task->sense.ascq == SCSI_SENSE_ASCQ_INVALID_FIELD_IN_CDB)) {
> /* WRITE SAME is not supported by the target */
> iscsilun->has_write_same = false;
> scsi_free_scsi_task(iTask.task);
I also checked that
SCSI_SENSE_ASCQ_INVALID_FIELD_IN_CDB
is available in libiscsi 1.4.0 already.
Reviewed-by: Peter Lieven <pl@kamp.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-02 20:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-02 12:45 [Qemu-devel] [PATCH for-2.0] iscsi: recognize "invalid field" ASCQ from WRITE SAME command Paolo Bonzini
2014-04-02 20:32 ` Peter Lieven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).