Re: [Qemu-devel] [PATCH v2 4/4] gtk: Add "Grab On Click" option

[Gerd Hoffmann <kraxel@redhat.com>]

On Mi, 2014-04-02 at 09:28 -0400, Cole Robinson wrote:
> On 04/02/2014 08:32 AM, Takashi Iwai wrote:
> > I simply like it better, you don't? :)
> > 
> 
> In fact, relative mouse mode is a pain without this feature, you need to
> manually initiate a grab with ctrl+alt+g before mouse movement will even work.
> Compare to our sdl front end, or virt-viewer, vinagre, virt-manager, where
> grab-on-click is the default (there isn't even an option to disable that
> behavior).
> 
> I don't know what the original intention of the code was, but I think this
> behavior should be the default. Anthony, Gerd, thoughts?

There are *two* grabs.  Pointer grab and keyboard grab.

grab-on-hover is for the keyboard, i.e. if the qemu gtk window has the
mouse focus it will grab the keyboard (if enabled), with the effect that
special keys like ctrl-alt-del are received by qemu and forwarded to the
guest instead of being intercepted by the hosts window manager.

grab-on-click is for the mouse.  I don't think we need an option for it,
instead it should depend on whenever the pointer works in absolute or
relative mode.  In absolute mode you don't need a pointer grab in the
first place.  Relative mode is pretty much unusable without pointer
grab.  Activating the pointer grab without a mouse click is pretty
annoying though.

hope that clarifies,
  Gerd