From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40674)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1WVMi9-0001wB-U1
	for qemu-devel@nongnu.org; Wed, 02 Apr 2014 11:04:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1WVMi3-0002sh-Ot
	for qemu-devel@nongnu.org; Wed, 02 Apr 2014 11:04:17 -0400
Received: from mx1.redhat.com ([209.132.183.28]:15201)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1WVMi3-0002sZ-I9
	for qemu-devel@nongnu.org; Wed, 02 Apr 2014 11:04:11 -0400
Message-ID: <1396449543.31715.7.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Wed, 02 Apr 2014 16:39:03 +0200
In-Reply-To: <533C1096.30904@redhat.com>
References: <1396441953-19260-1-git-send-email-tiwai@suse.de>
	<1396441953-19260-5-git-send-email-tiwai@suse.de>
	<533C1096.30904@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 4/4] gtk: Add "Grab On Click" option
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cole Robinson <crobinso@redhat.com>
Cc: Takashi Iwai <tiwai@suse.de>, qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>

On Mi, 2014-04-02 at 09:28 -0400, Cole Robinson wrote:
> On 04/02/2014 08:32 AM, Takashi Iwai wrote:
> > I simply like it better, you don't? :)
> > 
> 
> In fact, relative mouse mode is a pain without this feature, you need to
> manually initiate a grab with ctrl+alt+g before mouse movement will even work.
> Compare to our sdl front end, or virt-viewer, vinagre, virt-manager, where
> grab-on-click is the default (there isn't even an option to disable that
> behavior).
> 
> I don't know what the original intention of the code was, but I think this
> behavior should be the default. Anthony, Gerd, thoughts?

There are *two* grabs.  Pointer grab and keyboard grab.

grab-on-hover is for the keyboard, i.e. if the qemu gtk window has the
mouse focus it will grab the keyboard (if enabled), with the effect that
special keys like ctrl-alt-del are received by qemu and forwarded to the
guest instead of being intercepted by the hosts window manager.

grab-on-click is for the mouse.  I don't think we need an option for it,
instead it should depend on whenever the pointer works in absolute or
relative mode.  In absolute mode you don't need a pointer grab in the
first place.  Relative mode is pretty much unusable without pointer
grab.  Activating the pointer grab without a mouse click is pretty
annoying though.

hope that clarifies,
  Gerd