From: Gerd Hoffmann <kraxel@redhat.com>
To: Cole Robinson <crobinso@redhat.com>
Cc: tiwai@suse.de, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] gtk: Grab pointer on click when in relative mode
Date: Wed, 02 Apr 2014 17:19:51 +0200 [thread overview]
Message-ID: <1396451991.31715.25.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <6654339de9ab8191d7a11ce68194b9cd27471d54.1396451183.git.crobinso@redhat.com>
On Mi, 2014-04-02 at 11:07 -0400, Cole Robinson wrote:
> + if (button->button == 1 &&
> + button->type == GDK_BUTTON_PRESS &&
> + !gd_is_grab_active(s) &&
> + !qemu_input_is_absolute()) {
> +
> gtk_check_menu_item_set_active(GTK_CHECK_MENU_ITEM(s->grab_item),
> + TRUE);
> + return TRUE;
> + }
Looks sane on a quick glance (as replacement for patch #4 of Takashi's
patch series). Didn't test yet.
cheers,
Gerd
next prev parent reply other threads:[~2014-04-02 15:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 12:32 [Qemu-devel] [PATCH v2 0/4] Fix relative pointer tracking on Gtk UI (v2) Takashi Iwai
2014-04-02 12:32 ` [Qemu-devel] [PATCH v2 1/4] gtk: Use gtk generic event signal instead of motion-notify-event Takashi Iwai
2014-04-02 13:25 ` Cole Robinson
2014-04-02 15:17 ` Gerd Hoffmann
2014-04-02 15:26 ` Takashi Iwai
2014-04-02 12:32 ` [Qemu-devel] [PATCH v2 2/4] gtk: Fix the relative pointer tracking mode Takashi Iwai
2014-04-02 13:26 ` Cole Robinson
2014-04-02 12:32 ` [Qemu-devel] [PATCH v2 3/4] gtk: Remember the last grabbed pointer position Takashi Iwai
2014-04-02 13:27 ` Cole Robinson
2014-04-02 12:32 ` [Qemu-devel] [PATCH v2 4/4] gtk: Add "Grab On Click" option Takashi Iwai
2014-04-02 13:28 ` Cole Robinson
2014-04-02 13:42 ` Takashi Iwai
2014-04-02 13:49 ` Cole Robinson
2014-04-02 14:39 ` Gerd Hoffmann
2014-04-02 15:07 ` [Qemu-devel] [PATCH] gtk: Grab pointer on click when in relative mode Cole Robinson
2014-04-02 15:19 ` Gerd Hoffmann [this message]
2014-04-02 15:25 ` Takashi Iwai
2014-04-02 20:18 ` Cole Robinson
2014-04-03 6:19 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396451991.31715.25.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=crobinso@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).