From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45370)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1WVMxO-0001tZ-6z
	for qemu-devel@nongnu.org; Wed, 02 Apr 2014 11:20:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1WVMxH-0000AD-Vu
	for qemu-devel@nongnu.org; Wed, 02 Apr 2014 11:20:02 -0400
Received: from mx1.redhat.com ([209.132.183.28]:39684)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1WVMxH-0000A1-NQ
	for qemu-devel@nongnu.org; Wed, 02 Apr 2014 11:19:55 -0400
Message-ID: <1396451991.31715.25.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Wed, 02 Apr 2014 17:19:51 +0200
In-Reply-To: <6654339de9ab8191d7a11ce68194b9cd27471d54.1396451183.git.crobinso@redhat.com>
References: <1396449543.31715.7.camel@nilsson.home.kraxel.org>
	<6654339de9ab8191d7a11ce68194b9cd27471d54.1396451183.git.crobinso@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] gtk: Grab pointer on click when in
	relative mode
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cole Robinson <crobinso@redhat.com>
Cc: tiwai@suse.de, qemu-devel@nongnu.org

On Mi, 2014-04-02 at 11:07 -0400, Cole Robinson wrote:
> +    if (button->button == 1 &&
> +        button->type == GDK_BUTTON_PRESS &&
> +        !gd_is_grab_active(s) &&
> +        !qemu_input_is_absolute()) {
> +
> gtk_check_menu_item_set_active(GTK_CHECK_MENU_ITEM(s->grab_item),
> +                                       TRUE);
> +        return TRUE;
> +    }

Looks sane on a quick glance (as replacement for patch #4 of Takashi's
patch series).  Didn't test yet.

cheers,
  Gerd