qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Chunyan Liu <cyliu@suse.com>
To: qemu-devel@nongnu.org
Cc: l@dorileo.org, stefanha@redhat.com
Subject: [Qemu-devel] [PATCH v24 11/31] qemu_opts_print: change fprintf stderr to printf
Date: Thu,  3 Apr 2014 17:54:29 +0800	[thread overview]
Message-ID: <1396518889-21681-12-git-send-email-cyliu@suse.com> (raw)
In-Reply-To: <1396518889-21681-1-git-send-email-cyliu@suse.com>

Currently this function is not used anywhere. In later patches, it will
replace print_option_parameters. print_option_parameters uses printf,
to avoid print info changes after switching to QemuOpts, change
qemu_opts_print from fprintf stderr to printf to keep consistent.

Also to avoid print info changes, remove last printf and print size/number
with opt->value.uint instead of opt->str.

Signed-off-by: Chunyan Liu <cyliu@suse.com>
---
Changes:
  * remove last printf
  * add printf opt->value.uint for size/number type, keep same with
    QEMUOptionParameter print. (e.g. 10M printed as 10485760)

 util/qemu-option.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/util/qemu-option.c b/util/qemu-option.c
index c4c7545..dc484a9 100644
--- a/util/qemu-option.c
+++ b/util/qemu-option.c
@@ -1032,7 +1032,7 @@ void qemu_opts_print(QemuOpts *opts)
 
     if (desc[0].name == NULL) {
         QTAILQ_FOREACH(opt, &opts->head, next) {
-            fprintf(stderr, "%s=\"%s\" ", opt->name, opt->str);
+            printf("%s=\"%s\" ", opt->name, opt->str);
         }
         return;
     }
@@ -1045,12 +1045,14 @@ void qemu_opts_print(QemuOpts *opts)
             continue;
         }
         if (desc->type == QEMU_OPT_STRING) {
-            fprintf(stderr, "%s='%s' ", desc->name, value);
+            printf("%s='%s' ", desc->name, value);
+        } else if ((desc->type == QEMU_OPT_SIZE ||
+                    desc->type == QEMU_OPT_NUMBER) && opt) {
+            printf("%s=%" PRId64 " ", desc->name, opt->value.uint);
         } else {
-            fprintf(stderr, "%s=%s ", desc->name, value);
+            printf("%s=%s ", desc->name, value);
         }
     }
-    fprintf(stderr, "\n");
 }
 
 static int opts_do_parse(QemuOpts *opts, const char *params,
-- 
1.7.12.4

  parent reply	other threads:[~2014-04-03  9:54 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-03  9:54 [Qemu-devel] [PATCH v24 00/31] replace QEMUOptionParameter with QemuOpts Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 01/31] QemuOpts: move find_desc_by_name ahead for later calling Chunyan Liu
2014-04-08  1:17   ` Leandro Dorileo
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 02/31] QemuOpts: add def_value_str to QemuOptDesc Chunyan Liu
2014-04-08  1:31   ` Leandro Dorileo
2014-04-10  3:36     ` Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 03/31] qapi: output def_value_str when query command line options Chunyan Liu
2014-04-08  1:49   ` Leandro Dorileo
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 04/31] QemuOpts: change opt->name|str from (const char *) to (char *) Chunyan Liu
2014-04-08  1:51   ` Leandro Dorileo
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 05/31] QemuOpts: move qemu_opt_del ahead for later calling Chunyan Liu
2014-04-08  1:51   ` Leandro Dorileo
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 06/31] QemuOpts: add qemu_opt_get_*_del functions for replace work Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 07/31] QemuOpts: add qemu_opts_print_help to replace print_option_help Chunyan Liu
2014-04-08  1:34   ` Leandro Dorileo
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 08/31] QemuOpts: add conversion between QEMUOptionParameter to QemuOpts Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 09/31] QemuOpts: add qemu_opts_append to replace append_option_parameters Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 10/31] QemuOpts: check NULL input for qemu_opts_del Chunyan Liu
2014-04-03  9:54 ` Chunyan Liu [this message]
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 12/31] change block layer to support both QemuOpts and QEMUOptionParamter Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 13/31] vvfat.c: handle cross_driver's create_options and create_opts Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 14/31] cow.c: replace QEMUOptionParameter with QemuOpts Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 15/31] gluster.c: " Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 16/31] iscsi.c: " Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 17/31] qcow.c: " Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 18/31] qcow2.c: " Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 19/31] qed.c: " Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 20/31] raw-posix.c: " Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 21/31] raw-win32.c: " Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 22/31] raw_bsd.c: " Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 23/31] rbd.c: " Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 24/31] sheepdog.c: " Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 25/31] ssh.c: " Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 26/31] vdi.c: " Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 27/31] vhdx.c: " Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 28/31] vmdk.c: " Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 29/31] vpc.c: " Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 30/31] cleanup QEMUOptionParameter Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 31/31] QemuOpts: cleanup tmp 'allocated' member from QemuOptsList Chunyan Liu
2014-04-08  1:12 ` [Qemu-devel] [PATCH v24 00/31] replace QEMUOptionParameter with QemuOpts Leandro Dorileo
2014-04-10  3:20   ` Chunyan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1396518889-21681-12-git-send-email-cyliu@suse.com \
    --to=cyliu@suse.com \
    --cc=l@dorileo.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).