From: Chunyan Liu <cyliu@suse.com>
To: qemu-devel@nongnu.org
Cc: l@dorileo.org, stefanha@redhat.com
Subject: [Qemu-devel] [PATCH v24 21/31] raw-win32.c: replace QEMUOptionParameter with QemuOpts
Date: Thu, 3 Apr 2014 17:54:39 +0800 [thread overview]
Message-ID: <1396518889-21681-22-git-send-email-cyliu@suse.com> (raw)
In-Reply-To: <1396518889-21681-1-git-send-email-cyliu@suse.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Signed-off-by: Chunyan Liu <cyliu@suse.com>
---
block/raw-win32.c | 38 +++++++++++++++++++-------------------
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/block/raw-win32.c b/block/raw-win32.c
index 48cb2c2..b00d7fc 100644
--- a/block/raw-win32.c
+++ b/block/raw-win32.c
@@ -475,8 +475,7 @@ static int64_t raw_get_allocated_file_size(BlockDriverState *bs)
return st.st_size;
}
-static int raw_create(const char *filename, QEMUOptionParameter *options,
- Error **errp)
+static int raw_create(const char *filename, QemuOpts *opts, Error **errp)
{
int fd;
int64_t total_size = 0;
@@ -484,12 +483,8 @@ static int raw_create(const char *filename, QEMUOptionParameter *options,
strstart(filename, "file:", &filename);
/* Read out options */
- while (options && options->name) {
- if (!strcmp(options->name, BLOCK_OPT_SIZE)) {
- total_size = options->value.n / 512;
- }
- options++;
- }
+ total_size =
+ qemu_opt_get_size_del(opts, BLOCK_OPT_SIZE, 0) / 512;
fd = qemu_open(filename, O_WRONLY | O_CREAT | O_TRUNC | O_BINARY,
0644);
@@ -503,13 +498,18 @@ static int raw_create(const char *filename, QEMUOptionParameter *options,
return 0;
}
-static QEMUOptionParameter raw_create_options[] = {
- {
- .name = BLOCK_OPT_SIZE,
- .type = OPT_SIZE,
- .help = "Virtual disk size"
- },
- { NULL }
+
+static QemuOptsList raw_create_opts = {
+ .name = "raw-create-opts",
+ .head = QTAILQ_HEAD_INITIALIZER(raw_create_opts.head),
+ .desc = {
+ {
+ .name = BLOCK_OPT_SIZE,
+ .type = QEMU_OPT_SIZE,
+ .help = "Virtual disk size"
+ },
+ { /* end of list */ }
+ }
};
static BlockDriver bdrv_file = {
@@ -518,9 +518,9 @@ static BlockDriver bdrv_file = {
.instance_size = sizeof(BDRVRawState),
.bdrv_needs_filename = true,
.bdrv_parse_filename = raw_parse_filename,
- .bdrv_file_open = raw_open,
- .bdrv_close = raw_close,
- .bdrv_create = raw_create,
+ .bdrv_file_open = raw_open,
+ .bdrv_close = raw_close,
+ .bdrv_create2 = raw_create,
.bdrv_has_zero_init = bdrv_has_zero_init_1,
.bdrv_aio_readv = raw_aio_readv,
@@ -532,7 +532,7 @@ static BlockDriver bdrv_file = {
.bdrv_get_allocated_file_size
= raw_get_allocated_file_size,
- .create_options = raw_create_options,
+ .create_opts = &raw_create_opts,
};
/***********************************************/
--
1.7.12.4
next prev parent reply other threads:[~2014-04-03 9:54 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-03 9:54 [Qemu-devel] [PATCH v24 00/31] replace QEMUOptionParameter with QemuOpts Chunyan Liu
2014-04-03 9:54 ` [Qemu-devel] [PATCH v24 01/31] QemuOpts: move find_desc_by_name ahead for later calling Chunyan Liu
2014-04-08 1:17 ` Leandro Dorileo
2014-04-03 9:54 ` [Qemu-devel] [PATCH v24 02/31] QemuOpts: add def_value_str to QemuOptDesc Chunyan Liu
2014-04-08 1:31 ` Leandro Dorileo
2014-04-10 3:36 ` Chunyan Liu
2014-04-03 9:54 ` [Qemu-devel] [PATCH v24 03/31] qapi: output def_value_str when query command line options Chunyan Liu
2014-04-08 1:49 ` Leandro Dorileo
2014-04-03 9:54 ` [Qemu-devel] [PATCH v24 04/31] QemuOpts: change opt->name|str from (const char *) to (char *) Chunyan Liu
2014-04-08 1:51 ` Leandro Dorileo
2014-04-03 9:54 ` [Qemu-devel] [PATCH v24 05/31] QemuOpts: move qemu_opt_del ahead for later calling Chunyan Liu
2014-04-08 1:51 ` Leandro Dorileo
2014-04-03 9:54 ` [Qemu-devel] [PATCH v24 06/31] QemuOpts: add qemu_opt_get_*_del functions for replace work Chunyan Liu
2014-04-03 9:54 ` [Qemu-devel] [PATCH v24 07/31] QemuOpts: add qemu_opts_print_help to replace print_option_help Chunyan Liu
2014-04-08 1:34 ` Leandro Dorileo
2014-04-03 9:54 ` [Qemu-devel] [PATCH v24 08/31] QemuOpts: add conversion between QEMUOptionParameter to QemuOpts Chunyan Liu
2014-04-03 9:54 ` [Qemu-devel] [PATCH v24 09/31] QemuOpts: add qemu_opts_append to replace append_option_parameters Chunyan Liu
2014-04-03 9:54 ` [Qemu-devel] [PATCH v24 10/31] QemuOpts: check NULL input for qemu_opts_del Chunyan Liu
2014-04-03 9:54 ` [Qemu-devel] [PATCH v24 11/31] qemu_opts_print: change fprintf stderr to printf Chunyan Liu
2014-04-03 9:54 ` [Qemu-devel] [PATCH v24 12/31] change block layer to support both QemuOpts and QEMUOptionParamter Chunyan Liu
2014-04-03 9:54 ` [Qemu-devel] [PATCH v24 13/31] vvfat.c: handle cross_driver's create_options and create_opts Chunyan Liu
2014-04-03 9:54 ` [Qemu-devel] [PATCH v24 14/31] cow.c: replace QEMUOptionParameter with QemuOpts Chunyan Liu
2014-04-03 9:54 ` [Qemu-devel] [PATCH v24 15/31] gluster.c: " Chunyan Liu
2014-04-03 9:54 ` [Qemu-devel] [PATCH v24 16/31] iscsi.c: " Chunyan Liu
2014-04-03 9:54 ` [Qemu-devel] [PATCH v24 17/31] qcow.c: " Chunyan Liu
2014-04-03 9:54 ` [Qemu-devel] [PATCH v24 18/31] qcow2.c: " Chunyan Liu
2014-04-03 9:54 ` [Qemu-devel] [PATCH v24 19/31] qed.c: " Chunyan Liu
2014-04-03 9:54 ` [Qemu-devel] [PATCH v24 20/31] raw-posix.c: " Chunyan Liu
2014-04-03 9:54 ` Chunyan Liu [this message]
2014-04-03 9:54 ` [Qemu-devel] [PATCH v24 22/31] raw_bsd.c: " Chunyan Liu
2014-04-03 9:54 ` [Qemu-devel] [PATCH v24 23/31] rbd.c: " Chunyan Liu
2014-04-03 9:54 ` [Qemu-devel] [PATCH v24 24/31] sheepdog.c: " Chunyan Liu
2014-04-03 9:54 ` [Qemu-devel] [PATCH v24 25/31] ssh.c: " Chunyan Liu
2014-04-03 9:54 ` [Qemu-devel] [PATCH v24 26/31] vdi.c: " Chunyan Liu
2014-04-03 9:54 ` [Qemu-devel] [PATCH v24 27/31] vhdx.c: " Chunyan Liu
2014-04-03 9:54 ` [Qemu-devel] [PATCH v24 28/31] vmdk.c: " Chunyan Liu
2014-04-03 9:54 ` [Qemu-devel] [PATCH v24 29/31] vpc.c: " Chunyan Liu
2014-04-03 9:54 ` [Qemu-devel] [PATCH v24 30/31] cleanup QEMUOptionParameter Chunyan Liu
2014-04-03 9:54 ` [Qemu-devel] [PATCH v24 31/31] QemuOpts: cleanup tmp 'allocated' member from QemuOptsList Chunyan Liu
2014-04-08 1:12 ` [Qemu-devel] [PATCH v24 00/31] replace QEMUOptionParameter with QemuOpts Leandro Dorileo
2014-04-10 3:20 ` Chunyan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396518889-21681-22-git-send-email-cyliu@suse.com \
--to=cyliu@suse.com \
--cc=l@dorileo.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).