qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Chunyan Liu <cyliu@suse.com>
To: qemu-devel@nongnu.org
Cc: l@dorileo.org, stefanha@redhat.com
Subject: [Qemu-devel] [PATCH v24 03/31] qapi: output def_value_str when query command line options
Date: Thu,  3 Apr 2014 17:54:21 +0800	[thread overview]
Message-ID: <1396518889-21681-4-git-send-email-cyliu@suse.com> (raw)
In-Reply-To: <1396518889-21681-1-git-send-email-cyliu@suse.com>

Change qapi interfaces to output the newly added def_value_str when querying
command line options.

Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Signed-off-by: Chunyan Liu <cyliu@suse.com>
---
 qapi-schema.json   | 6 +++++-
 qmp-commands.hx    | 2 ++
 util/qemu-config.c | 4 ++++
 3 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/qapi-schema.json b/qapi-schema.json
index 391356f..f04ea18 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -4088,12 +4088,16 @@
 #
 # @help: #optional human readable text string, not suitable for parsing.
 #
+# @default: #optional string representation of the default used
+#           if the option is omitted. (since 2.1)
+#
 # Since 1.5
 ##
 { 'type': 'CommandLineParameterInfo',
   'data': { 'name': 'str',
             'type': 'CommandLineParameterType',
-            '*help': 'str' } }
+            '*help': 'str',
+            '*default': 'str' } }
 
 ##
 # @CommandLineOptionInfo:
diff --git a/qmp-commands.hx b/qmp-commands.hx
index ed3ab92..1271332 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -2895,6 +2895,8 @@ Each array entry contains the following:
               or 'size')
     - "help": human readable description of the parameter
               (json-string, optional)
+    - "default": default value string for the parameter
+                 (json-string, optional)
 
 Example:
 
diff --git a/util/qemu-config.c b/util/qemu-config.c
index f610101..d608b2f 100644
--- a/util/qemu-config.c
+++ b/util/qemu-config.c
@@ -68,6 +68,10 @@ static CommandLineParameterInfoList *query_option_descs(const QemuOptDesc *desc)
             info->has_help = true;
             info->help = g_strdup(desc[i].help);
         }
+        if (desc[i].def_value_str) {
+            info->has_q_default = true;
+            info->q_default = g_strdup(desc[i].def_value_str);
+        }
 
         entry = g_malloc0(sizeof(*entry));
         entry->value = info;
-- 
1.7.12.4

  parent reply	other threads:[~2014-04-03  9:53 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-03  9:54 [Qemu-devel] [PATCH v24 00/31] replace QEMUOptionParameter with QemuOpts Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 01/31] QemuOpts: move find_desc_by_name ahead for later calling Chunyan Liu
2014-04-08  1:17   ` Leandro Dorileo
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 02/31] QemuOpts: add def_value_str to QemuOptDesc Chunyan Liu
2014-04-08  1:31   ` Leandro Dorileo
2014-04-10  3:36     ` Chunyan Liu
2014-04-03  9:54 ` Chunyan Liu [this message]
2014-04-08  1:49   ` [Qemu-devel] [PATCH v24 03/31] qapi: output def_value_str when query command line options Leandro Dorileo
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 04/31] QemuOpts: change opt->name|str from (const char *) to (char *) Chunyan Liu
2014-04-08  1:51   ` Leandro Dorileo
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 05/31] QemuOpts: move qemu_opt_del ahead for later calling Chunyan Liu
2014-04-08  1:51   ` Leandro Dorileo
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 06/31] QemuOpts: add qemu_opt_get_*_del functions for replace work Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 07/31] QemuOpts: add qemu_opts_print_help to replace print_option_help Chunyan Liu
2014-04-08  1:34   ` Leandro Dorileo
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 08/31] QemuOpts: add conversion between QEMUOptionParameter to QemuOpts Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 09/31] QemuOpts: add qemu_opts_append to replace append_option_parameters Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 10/31] QemuOpts: check NULL input for qemu_opts_del Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 11/31] qemu_opts_print: change fprintf stderr to printf Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 12/31] change block layer to support both QemuOpts and QEMUOptionParamter Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 13/31] vvfat.c: handle cross_driver's create_options and create_opts Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 14/31] cow.c: replace QEMUOptionParameter with QemuOpts Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 15/31] gluster.c: " Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 16/31] iscsi.c: " Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 17/31] qcow.c: " Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 18/31] qcow2.c: " Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 19/31] qed.c: " Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 20/31] raw-posix.c: " Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 21/31] raw-win32.c: " Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 22/31] raw_bsd.c: " Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 23/31] rbd.c: " Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 24/31] sheepdog.c: " Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 25/31] ssh.c: " Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 26/31] vdi.c: " Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 27/31] vhdx.c: " Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 28/31] vmdk.c: " Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 29/31] vpc.c: " Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 30/31] cleanup QEMUOptionParameter Chunyan Liu
2014-04-03  9:54 ` [Qemu-devel] [PATCH v24 31/31] QemuOpts: cleanup tmp 'allocated' member from QemuOptsList Chunyan Liu
2014-04-08  1:12 ` [Qemu-devel] [PATCH v24 00/31] replace QEMUOptionParameter with QemuOpts Leandro Dorileo
2014-04-10  3:20   ` Chunyan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1396518889-21681-4-git-send-email-cyliu@suse.com \
    --to=cyliu@suse.com \
    --cc=l@dorileo.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).