From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 1/4] scsi-bus: remove bogus assertion
Date: Thu, 3 Apr 2014 13:12:18 +0200 [thread overview]
Message-ID: <1396523541-568-2-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1396523541-568-1-git-send-email-pbonzini@redhat.com>
This assertion is invalid, because get_sg_list can return an
empty sg-list even for commands that transfer no data (such
as SYNCHRONIZE CACHE).
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/scsi/scsi-bus.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c
index eaad925..ae921a6 100644
--- a/hw/scsi/scsi-bus.c
+++ b/hw/scsi/scsi-bus.c
@@ -101,7 +101,6 @@ static void scsi_dma_restart_bh(void *opaque)
scsi_req_continue(req);
break;
case SCSI_XFER_NONE:
- assert(!req->sg);
scsi_req_dequeue(req);
scsi_req_enqueue(req);
break;
--
1.9.0
next prev parent reply other threads:[~2014-04-03 11:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-03 11:12 [Qemu-devel] [PULL for-2.0 0/4] SCSI changes for QEMU 2.0 Paolo Bonzini
2014-04-03 11:12 ` Paolo Bonzini [this message]
2014-04-03 11:12 ` [Qemu-devel] [PULL 2/4] iscsi: recognize "invalid field" ASCQ from WRITE SAME command Paolo Bonzini
2014-04-03 11:12 ` [Qemu-devel] [PULL 3/4] iscsi: ignore flushes on scsi-generic devices Paolo Bonzini
2014-04-03 11:12 ` [Qemu-devel] [PULL 4/4] iscsi: always query max WRITE SAME length Paolo Bonzini
2014-04-03 12:03 ` [Qemu-devel] [PULL for-2.0 0/4] SCSI changes for QEMU 2.0 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396523541-568-2-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).