From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50897) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVfZc-0003hU-9H for qemu-devel@nongnu.org; Thu, 03 Apr 2014 07:12:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WVfZT-0002bI-4G for qemu-devel@nongnu.org; Thu, 03 Apr 2014 07:12:44 -0400 Received: from mail-qc0-x236.google.com ([2607:f8b0:400d:c01::236]:48320) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVfZT-0002bE-0D for qemu-devel@nongnu.org; Thu, 03 Apr 2014 07:12:35 -0400 Received: by mail-qc0-f182.google.com with SMTP id e16so1666094qcx.27 for ; Thu, 03 Apr 2014 04:12:34 -0700 (PDT) Received: from yakj.usersys.redhat.com (net-2-35-193-100.cust.vodafonedsl.it. [2.35.193.100]) by mx.google.com with ESMTPSA id b37sm6468572qge.16.2014.04.03.04.12.33 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 Apr 2014 04:12:34 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Thu, 3 Apr 2014 13:12:18 +0200 Message-Id: <1396523541-568-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1396523541-568-1-git-send-email-pbonzini@redhat.com> References: <1396523541-568-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PULL 1/4] scsi-bus: remove bogus assertion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This assertion is invalid, because get_sg_list can return an empty sg-list even for commands that transfer no data (such as SYNCHRONIZE CACHE). Signed-off-by: Paolo Bonzini --- hw/scsi/scsi-bus.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c index eaad925..ae921a6 100644 --- a/hw/scsi/scsi-bus.c +++ b/hw/scsi/scsi-bus.c @@ -101,7 +101,6 @@ static void scsi_dma_restart_bh(void *opaque) scsi_req_continue(req); break; case SCSI_XFER_NONE: - assert(!req->sg); scsi_req_dequeue(req); scsi_req_enqueue(req); break; -- 1.9.0