From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 3/4] iscsi: ignore flushes on scsi-generic devices
Date: Thu, 3 Apr 2014 13:12:20 +0200 [thread overview]
Message-ID: <1396523541-568-4-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1396523541-568-1-git-send-email-pbonzini@redhat.com>
Non-block SCSI devices do not support flushing, but we may still send
them requests via bdrv_flush_all. Just ignore them.
Reviewed-by: Peter Lieven <pl@kamp.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
block/iscsi.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/block/iscsi.c b/block/iscsi.c
index 2f96a8e..e68aa0f 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -417,6 +417,10 @@ static int coroutine_fn iscsi_co_flush(BlockDriverState *bs)
IscsiLun *iscsilun = bs->opaque;
struct IscsiTask iTask;
+ if (bs->sg) {
+ return 0;
+ }
+
iscsi_co_init_iscsitask(iscsilun, &iTask);
retry:
--
1.9.0
next prev parent reply other threads:[~2014-04-03 11:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-03 11:12 [Qemu-devel] [PULL for-2.0 0/4] SCSI changes for QEMU 2.0 Paolo Bonzini
2014-04-03 11:12 ` [Qemu-devel] [PULL 1/4] scsi-bus: remove bogus assertion Paolo Bonzini
2014-04-03 11:12 ` [Qemu-devel] [PULL 2/4] iscsi: recognize "invalid field" ASCQ from WRITE SAME command Paolo Bonzini
2014-04-03 11:12 ` Paolo Bonzini [this message]
2014-04-03 11:12 ` [Qemu-devel] [PULL 4/4] iscsi: always query max WRITE SAME length Paolo Bonzini
2014-04-03 12:03 ` [Qemu-devel] [PULL for-2.0 0/4] SCSI changes for QEMU 2.0 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396523541-568-4-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).