From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50899) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVfZc-0003i0-Co for qemu-devel@nongnu.org; Thu, 03 Apr 2014 07:12:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WVfZW-0002ch-JP for qemu-devel@nongnu.org; Thu, 03 Apr 2014 07:12:44 -0400 Received: from mail-qc0-x236.google.com ([2607:f8b0:400d:c01::236]:32894) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVfZW-0002cd-FN for qemu-devel@nongnu.org; Thu, 03 Apr 2014 07:12:38 -0400 Received: by mail-qc0-f182.google.com with SMTP id e16so1673110qcx.13 for ; Thu, 03 Apr 2014 04:12:38 -0700 (PDT) Received: from yakj.usersys.redhat.com (net-2-35-193-100.cust.vodafonedsl.it. [2.35.193.100]) by mx.google.com with ESMTPSA id b37sm6468572qge.16.2014.04.03.04.12.36 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 Apr 2014 04:12:37 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Thu, 3 Apr 2014 13:12:20 +0200 Message-Id: <1396523541-568-4-git-send-email-pbonzini@redhat.com> In-Reply-To: <1396523541-568-1-git-send-email-pbonzini@redhat.com> References: <1396523541-568-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PULL 3/4] iscsi: ignore flushes on scsi-generic devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Non-block SCSI devices do not support flushing, but we may still send them requests via bdrv_flush_all. Just ignore them. Reviewed-by: Peter Lieven Signed-off-by: Paolo Bonzini --- block/iscsi.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index 2f96a8e..e68aa0f 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -417,6 +417,10 @@ static int coroutine_fn iscsi_co_flush(BlockDriverState *bs) IscsiLun *iscsilun = bs->opaque; struct IscsiTask iTask; + if (bs->sg) { + return 0; + } + iscsi_co_init_iscsitask(iscsilun, &iTask); retry: -- 1.9.0