From: Marcel Apfelbaum <marcel.a@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: peter.maydell@linaro.org, famz@redhat.com, stefanha@redhat.com,
mst@redhat.com, rth@twiddle.net,
stefano.stabellini@eu.citrix.com, qemu-devel@nongnu.org,
armbru@redhat.com, agraf@suse.de, alex@alex.org.uk,
pbonzini@redhat.com, lcapitulino@redhat.com, aliguori@amazon.com
Subject: Re: [Qemu-devel] [PATCH V2 4/5] hw/ppc: remove QEMUMachine indirection
Date: Thu, 03 Apr 2014 20:46:46 +0300 [thread overview]
Message-ID: <1396547206.24348.55.camel@localhost.localdomain> (raw)
In-Reply-To: <533D997A.6040604@suse.de>
On Thu, 2014-04-03 at 19:25 +0200, Andreas Färber wrote:
> Am 31.03.2014 11:26, schrieb Marcel Apfelbaum:
> > No need for QEMUMachine anymore because
> > its fields are passed to MachineClass.
>
> QEMUMachineInitArgs still has a QEMUMachine field that now becomes NULL?
No...
It is properly initiated right before the machine init: (No changes made)
QEMUMachineInitArgs args = { .machine = machine,
.ram_size = ram_size,
.boot_order = boot_order,
.kernel_filename = kernel_filename,
.kernel_cmdline = kernel_cmdline,
.initrd_filename = initrd_filename,
.cpu_model = cpu_model };
current_machine->init_args = args;
machine->init(¤t_machine->init_args);
I plan to get rid of this too, but it touches a lot of files,
I am looking for a clean way to get rid of it.
Thanks,
Marcel
>
> Andreas
>
next prev parent reply other threads:[~2014-04-03 17:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-31 9:26 [Qemu-devel] [PATCH V2 0/5] remove QEMUMachine indirection from MachineClass Marcel Apfelbaum
2014-03-31 9:26 ` [Qemu-devel] [PATCH V2 1/5] hw/boards.h: add QEMUMachine's fields to MachineClass Marcel Apfelbaum
2014-03-31 9:26 ` [Qemu-devel] [PATCH V2 2/5] machine: remove QEMUMachine indirection from MachineClass Marcel Apfelbaum
2014-04-03 16:59 ` Andreas Färber
2014-04-03 17:11 ` Marcel Apfelbaum
2014-04-03 17:36 ` Andreas Färber
2014-04-03 17:40 ` Marcel Apfelbaum
2014-03-31 9:26 ` [Qemu-devel] [PATCH V2 3/5] machine: replace QEMUMachine by MachineClass in accelerator configuration Marcel Apfelbaum
2014-03-31 9:26 ` [Qemu-devel] [PATCH V2 4/5] hw/ppc: remove QEMUMachine indirection Marcel Apfelbaum
2014-04-03 17:25 ` Andreas Färber
2014-04-03 17:46 ` Marcel Apfelbaum [this message]
2014-04-03 17:57 ` Andreas Färber
2014-04-03 18:08 ` Marcel Apfelbaum
2014-03-31 9:26 ` [Qemu-devel] [PATCH V2 5/5] vl.c: Remove QEMUMachine usage Marcel Apfelbaum
2014-04-03 17:09 ` Andreas Färber
2014-04-03 17:12 ` Marcel Apfelbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396547206.24348.55.camel@localhost.localdomain \
--to=marcel.a@redhat.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=alex@alex.org.uk \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=famz@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
--cc=stefano.stabellini@eu.citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).