From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40446)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel.a@redhat.com>) id 1WVliq-0006jN-KI
	for qemu-devel@nongnu.org; Thu, 03 Apr 2014 13:46:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcel.a@redhat.com>) id 1WVlik-0001Ff-FE
	for qemu-devel@nongnu.org; Thu, 03 Apr 2014 13:46:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:11536)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel.a@redhat.com>) id 1WVlik-0001FS-79
	for qemu-devel@nongnu.org; Thu, 03 Apr 2014 13:46:34 -0400
Message-ID: <1396547206.24348.55.camel@localhost.localdomain>
From: Marcel Apfelbaum <marcel.a@redhat.com>
Date: Thu, 03 Apr 2014 20:46:46 +0300
In-Reply-To: <533D997A.6040604@suse.de>
References: <1396257993-4036-1-git-send-email-marcel.a@redhat.com>
	<1396257993-4036-5-git-send-email-marcel.a@redhat.com>
	<533D997A.6040604@suse.de>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH V2 4/5] hw/ppc: remove QEMUMachine
 indirection
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?ISO-8859-1?Q?F=E4rber?= <afaerber@suse.de>
Cc: peter.maydell@linaro.org, famz@redhat.com, stefanha@redhat.com, mst@redhat.com, rth@twiddle.net, stefano.stabellini@eu.citrix.com, qemu-devel@nongnu.org, armbru@redhat.com, agraf@suse.de, alex@alex.org.uk, pbonzini@redhat.com, lcapitulino@redhat.com, aliguori@amazon.com

On Thu, 2014-04-03 at 19:25 +0200, Andreas F=C3=A4rber wrote:
> Am 31.03.2014 11:26, schrieb Marcel Apfelbaum:
> > No need for QEMUMachine anymore because
> > its fields are passed to MachineClass.
>=20
> QEMUMachineInitArgs still has a QEMUMachine field that now becomes NULL=
?
No...=20
It is properly initiated right before the machine init: (No changes made)


   QEMUMachineInitArgs args =3D { .machine =3D machine,=20
                                .ram_size =3D ram_size,=20
                                .boot_order =3D boot_order,=20
                                .kernel_filename =3D kernel_filename,=20
                                .kernel_cmdline =3D kernel_cmdline,=20
                                .initrd_filename =3D initrd_filename,=20
                                .cpu_model =3D cpu_model };=20
  =20
   current_machine->init_args =3D args;=20
   machine->init(&current_machine->init_args);

I plan to get rid of this too, but it touches a lot of files,
I am looking for a clean way to get rid of it.

Thanks,
Marcel

>=20
> Andreas
>=20