From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46790) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVnlN-0007FJ-Qx for qemu-devel@nongnu.org; Thu, 03 Apr 2014 15:57:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WVnlH-0004eP-Rb for qemu-devel@nongnu.org; Thu, 03 Apr 2014 15:57:25 -0400 Received: from mail-qg0-x233.google.com ([2607:f8b0:400d:c04::233]:56341) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WVnlH-0004cq-LQ for qemu-devel@nongnu.org; Thu, 03 Apr 2014 15:57:19 -0400 Received: by mail-qg0-f51.google.com with SMTP id q108so2327627qgd.38 for ; Thu, 03 Apr 2014 12:57:18 -0700 (PDT) Sender: Richard Henderson From: Richard Henderson Date: Thu, 3 Apr 2014 12:56:32 -0700 Message-Id: <1396555000-8205-19-git-send-email-rth@twiddle.net> In-Reply-To: <1396555000-8205-1-git-send-email-rth@twiddle.net> References: <1396555000-8205-1-git-send-email-rth@twiddle.net> Subject: [Qemu-devel] [PATCH v3 18/26] tcg-aarch64: Pass qemu_ld/st arguments directly List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: claudio.fontana@gmail.com Instead of passing them the "args" array. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c | 49 +++++++++++++++++------------------------------- 1 file changed, 17 insertions(+), 32 deletions(-) diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target.c index 68305ea..3a2955f 100644 --- a/tcg/aarch64/tcg-target.c +++ b/tcg/aarch64/tcg-target.c @@ -1271,20 +1271,13 @@ static void tcg_out_qemu_st_direct(TCGContext *s, TCGMemOp memop, } } -static void tcg_out_qemu_ld(TCGContext *s, const TCGArg *args, TCGMemOp memop) +static void tcg_out_qemu_ld(TCGContext *s, TCGReg data_reg, TCGReg addr_reg, + TCGMemOp memop, int mem_index) { - TCGReg addr_reg, data_reg; #ifdef CONFIG_SOFTMMU - int mem_index; - TCGMemOp s_bits; + TCGMemOp s_bits = memop & MO_SIZE; uint8_t *label_ptr; -#endif - data_reg = args[0]; - addr_reg = args[1]; -#ifdef CONFIG_SOFTMMU - mem_index = args[2]; - s_bits = memop & MO_SIZE; tcg_out_tlb_read(s, addr_reg, s_bits, &label_ptr, mem_index, 1); tcg_out_qemu_ld_direct(s, memop, data_reg, addr_reg, TCG_REG_X1); add_qemu_ldst_label(s, 1, memop, data_reg, addr_reg, @@ -1295,20 +1288,12 @@ static void tcg_out_qemu_ld(TCGContext *s, const TCGArg *args, TCGMemOp memop) #endif /* CONFIG_SOFTMMU */ } -static void tcg_out_qemu_st(TCGContext *s, const TCGArg *args, TCGMemOp memop) +static void tcg_out_qemu_st(TCGContext *s, TCGReg data_reg, TCGReg addr_reg, + TCGMemOp memop, int mem_index) { - TCGReg addr_reg, data_reg; #ifdef CONFIG_SOFTMMU - int mem_index; - TCGMemOp s_bits; + TCGMemOp s_bits = memop & MO_SIZE; uint8_t *label_ptr; -#endif - data_reg = args[0]; - addr_reg = args[1]; - -#ifdef CONFIG_SOFTMMU - mem_index = args[2]; - s_bits = memop & MO_SIZE; tcg_out_tlb_read(s, addr_reg, s_bits, &label_ptr, mem_index, 0); tcg_out_qemu_st_direct(s, memop, data_reg, addr_reg, TCG_REG_X1); @@ -1588,38 +1573,38 @@ static void tcg_out_op(TCGContext *s, TCGOpcode opc, break; case INDEX_op_qemu_ld8u: - tcg_out_qemu_ld(s, args, MO_UB); + tcg_out_qemu_ld(s, a0, a1, MO_UB, a2); break; case INDEX_op_qemu_ld8s: - tcg_out_qemu_ld(s, args, MO_SB); + tcg_out_qemu_ld(s, a0, a1, MO_SB, a2); break; case INDEX_op_qemu_ld16u: - tcg_out_qemu_ld(s, args, MO_TEUW); + tcg_out_qemu_ld(s, a0, a1, MO_TEUW, a2); break; case INDEX_op_qemu_ld16s: - tcg_out_qemu_ld(s, args, MO_TESW); + tcg_out_qemu_ld(s, a0, a1, MO_TESW, a2); break; case INDEX_op_qemu_ld32u: case INDEX_op_qemu_ld32: - tcg_out_qemu_ld(s, args, MO_TEUL); + tcg_out_qemu_ld(s, a0, a1, MO_TEUL, a2); break; case INDEX_op_qemu_ld32s: - tcg_out_qemu_ld(s, args, MO_TESL); + tcg_out_qemu_ld(s, a0, a1, MO_TESL, a2); break; case INDEX_op_qemu_ld64: - tcg_out_qemu_ld(s, args, MO_TEQ); + tcg_out_qemu_ld(s, a0, a1, MO_TEQ, a2); break; case INDEX_op_qemu_st8: - tcg_out_qemu_st(s, args, MO_UB); + tcg_out_qemu_st(s, a0, a1, MO_UB, a2); break; case INDEX_op_qemu_st16: - tcg_out_qemu_st(s, args, MO_TEUW); + tcg_out_qemu_st(s, a0, a1, MO_TEUW, a2); break; case INDEX_op_qemu_st32: - tcg_out_qemu_st(s, args, MO_TEUL); + tcg_out_qemu_st(s, a0, a1, MO_TEUL, a2); break; case INDEX_op_qemu_st64: - tcg_out_qemu_st(s, args, MO_TEQ); + tcg_out_qemu_st(s, a0, a1, MO_TEQ, a2); break; case INDEX_op_bswap32_i64: -- 1.9.0