From: Gerd Hoffmann <kraxel@redhat.com>
To: "Ján Veselý" <jano.vesely@gmail.com>
Cc: QEMU <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2 1/2] usb-hid: Add high speed mouse configuration
Date: Mon, 07 Apr 2014 10:02:08 +0200 [thread overview]
Message-ID: <1396857728.5001.45.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <CA+K+NcStiYjgrRzmJkXuuJgx3p-6+Quu7_7ARuD_PquH0-uOfg@mail.gmail.com>
On Do, 2014-04-03 at 01:27 -0400, Ján Veselý wrote:
> ping2
>
> is there anything I can do to help these patches get merged?
Well, v2 is a step into the right direction but not complete yet. The
usb_ver property hasn't any effect for mouse and keyboard. Also we'll
need a compat property so older machine types continue to have usb1
mouse+keyboard.
The compat property stuff is a bit tricky so my plan was to just do that
myself, but I havn't found the time yet.
If you wanna tackle the challenge have a look at
427e3aa151c749225364d0c30640e2e3c1756d9d (tablet patch). keyboard+mouse
need to do the same.
Also some cleanups can be done, such as moving the "switch
(us->usb_version) { ... }" from usb_tablet_initfn to usb_hid_initfn to
avoid duplicating it.
cheers,
Gerd
next prev parent reply other threads:[~2014-04-07 8:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-16 5:41 [Qemu-devel] [PATCH 1/2] usb-hid: Add high speed mouse configuration Jan Vesely
2014-02-16 5:41 ` [Qemu-devel] [PATCH 2/2] usb-hid: Add high speed keyboard configuration Jan Vesely
2014-02-17 12:10 ` [Qemu-devel] [PATCH 1/2] usb-hid: Add high speed mouse configuration Gerd Hoffmann
2014-02-23 7:37 ` [Qemu-devel] [PATCH v2 " Jan Vesely
2014-02-23 7:37 ` [Qemu-devel] [PATCH v2 2/2] usb-hid: Add high speed keyboard configuration Jan Vesely
2014-03-17 17:53 ` [Qemu-devel] [PATCH v2 1/2] usb-hid: Add high speed mouse configuration Ján Veselý
2014-04-03 5:27 ` Ján Veselý
2014-04-07 8:02 ` Gerd Hoffmann [this message]
[not found] ` <CA+K+NcQZf-__sqSBTewBooUTUWMDP_m34iDVQX7YsHtUzAwb6g@mail.gmail.com>
[not found] ` <1397629640.23535.7.camel@nilsson.home.kraxel.org>
2014-09-11 4:57 ` Jan Vesely
2014-09-11 4:58 ` [Qemu-devel] [PATCH 1/3] usb-hid: Move descriptor decision to usb-hid initfn Jan Vesely
2014-09-11 4:58 ` [Qemu-devel] [PATCH v3 2/3] usb-hid: Add high speed mouse configuration Jan Vesely
2014-09-11 4:58 ` [Qemu-devel] [PATCH 3/3] usb-hid: Add high speed keyboard configuration Jan Vesely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396857728.5001.45.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=jano.vesely@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).