From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49294) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WX5N3-00057z-Eb for qemu-devel@nongnu.org; Mon, 07 Apr 2014 04:57:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WX5Mx-0005A6-2F for qemu-devel@nongnu.org; Mon, 07 Apr 2014 04:57:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15127) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WX5Mw-0005A1-Pf for qemu-devel@nongnu.org; Mon, 07 Apr 2014 04:57:30 -0400 From: Gerd Hoffmann Date: Mon, 7 Apr 2014 10:56:17 +0200 Message-Id: <1396860980-7130-2-git-send-email-kraxel@redhat.com> In-Reply-To: <1396860980-7130-1-git-send-email-kraxel@redhat.com> References: <1396860980-7130-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PULL 1/4] gtk: Use gtk generic event signal instead of motion-notify-event List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Takashi Iwai , Gerd Hoffmann , Anthony Liguori From: Takashi Iwai The GDK motion-notify-event isn't generated when the pointer goes out of the target window even if the pointer is grabbed, which essentially means to lose the pointer tracking in gtk-ui. Meanwhile the generic "event" signal is sent when the pointer is grabbed, so we can use this and pick the motion notify events manually there instead. Reference: https://bugzilla.novell.com/show_bug.cgi?id=849587 Tested-by: Cole Robinson Reviewed-by: Cole Robinson Tested-by: Michael S. Tsirkin Signed-off-by: Takashi Iwai Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index f056e40..c9f6d24 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -765,6 +765,14 @@ static gboolean gd_key_event(GtkWidget *widget, GdkEventKey *key, void *opaque) return TRUE; } +static gboolean gd_event(GtkWidget *widget, GdkEvent *event, void *opaque) +{ + if (event->type == GDK_MOTION_NOTIFY) { + return gd_motion_event(widget, &event->motion, opaque); + } + return FALSE; +} + /** Window Menu Actions **/ static void gd_menu_pause(GtkMenuItem *item, void *opaque) @@ -1267,8 +1275,8 @@ static void gd_connect_signals(GtkDisplayState *s) g_signal_connect(s->drawing_area, "expose-event", G_CALLBACK(gd_expose_event), s); #endif - g_signal_connect(s->drawing_area, "motion-notify-event", - G_CALLBACK(gd_motion_event), s); + g_signal_connect(s->drawing_area, "event", + G_CALLBACK(gd_event), s); g_signal_connect(s->drawing_area, "button-press-event", G_CALLBACK(gd_button_event), s); g_signal_connect(s->drawing_area, "button-release-event", -- 1.8.3.1