From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57940) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WX8FN-0007V7-32 for qemu-devel@nongnu.org; Mon, 07 Apr 2014 08:01:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WX8FF-0001uh-KO for qemu-devel@nongnu.org; Mon, 07 Apr 2014 08:01:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62686) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WX8FF-0001uX-Cr for qemu-devel@nongnu.org; Mon, 07 Apr 2014 08:01:45 -0400 Message-ID: <1396872101.5001.64.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Mon, 07 Apr 2014 14:01:41 +0200 In-Reply-To: <1396868342-12005-1-git-send-email-marcel.a@redhat.com> References: <1396868342-12005-1-git-send-email-marcel.a@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [SeaBIOS] [PATCH] hw/pci: reserve IO and mem for pci-2-pci bridges with no devices attached List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum Cc: seabios@seabios.org, qemu-devel@nongnu.org, mst@redhat.com On Mo, 2014-04-07 at 13:59 +0300, Marcel Apfelbaum wrote: > If a pci-2-pci bridge supports hot-plug functionality but there are no devices > connected to it, reserve IO/mem in order to be able to attach devices > later. Do not waste space, use minimum allowed. Makes sense. > + u8 shpc_cap = pci_find_capability(s->bus_dev, PCI_CAP_ID_SHPC); Should we also check for hotplug-capable pci express ports while being at it? cheers, Gerd