From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33006)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel.a@redhat.com>) id 1WX8VJ-0002qS-3T
	for qemu-devel@nongnu.org; Mon, 07 Apr 2014 08:18:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcel.a@redhat.com>) id 1WX8VA-0007W0-Ax
	for qemu-devel@nongnu.org; Mon, 07 Apr 2014 08:18:21 -0400
Received: from mx1.redhat.com ([209.132.183.28]:65526)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel.a@redhat.com>) id 1WX8VA-0007Vq-2r
	for qemu-devel@nongnu.org; Mon, 07 Apr 2014 08:18:12 -0400
Message-ID: <1396873116.10570.5.camel@localhost.localdomain>
From: Marcel Apfelbaum <marcel.a@redhat.com>
Date: Mon, 07 Apr 2014 15:18:36 +0300
In-Reply-To: <20140407121136.GC16369@redhat.com>
References: <1396868342-12005-1-git-send-email-marcel.a@redhat.com>
	<1396872101.5001.64.camel@nilsson.home.kraxel.org>
	<20140407121136.GC16369@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [SeaBIOS] [PATCH] hw/pci: reserve IO and mem for
 pci-2-pci bridges with no devices attached
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: seabios@seabios.org, Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org

On Mon, 2014-04-07 at 15:11 +0300, Michael S. Tsirkin wrote:
> On Mon, Apr 07, 2014 at 02:01:41PM +0200, Gerd Hoffmann wrote:
> > On Mo, 2014-04-07 at 13:59 +0300, Marcel Apfelbaum wrote:
> > > If a pci-2-pci bridge supports hot-plug functionality but there are no devices
> > > connected to it, reserve IO/mem in order to be able to attach devices
> > > later. Do not waste space, use minimum allowed.
> > 
> > Makes sense.
> > 
> > > +        u8 shpc_cap = pci_find_capability(s->bus_dev, PCI_CAP_ID_SHPC);
> > 
> > Should we also check for hotplug-capable pci express ports while being
> > at it?
> > 
> > cheers,
> >   Gerd
> > 
> 
> Can be a separate patch?
> 
I think it can be. This one handles pci-2-pci bridges and avoids PCIe by choice.
I do plan to handle PCIe hotplug corners later.

Thanks,
Marcel