From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50707) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WX9SV-0003S2-7z for qemu-devel@nongnu.org; Mon, 07 Apr 2014 09:19:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WX9SP-0004ix-Jg for qemu-devel@nongnu.org; Mon, 07 Apr 2014 09:19:31 -0400 Received: from mail-wi0-x22f.google.com ([2a00:1450:400c:c05::22f]:62247) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WX9SP-0004ic-C4 for qemu-devel@nongnu.org; Mon, 07 Apr 2014 09:19:25 -0400 Received: by mail-wi0-f175.google.com with SMTP id cc10so5045952wib.8 for ; Mon, 07 Apr 2014 06:19:24 -0700 (PDT) Message-ID: <1396876787.10570.12.camel@localhost.localdomain> From: Marcel Apfelbaum Date: Mon, 07 Apr 2014 16:19:47 +0300 In-Reply-To: <1396840915-10384-1-git-send-email-quintela@redhat.com> References: <1396840915-10384-1-git-send-email-quintela@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for 2.1 00/97] VMState simplification (massive) Reply-To: marcel.a@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org On Mon, 2014-04-07 at 05:20 +0200, Juan Quintela wrote: > Hi > > Look at the diffstat. Almost all the additions are at > test-vmstate.c. That is the reason why it is called a simplification. > > What this series does: > - peter removal of version_minimum_id_old field when not needed (Peter) > - cleanup: based on the previous one, I removed all the unneeded > the uses on the tree. This should make your compiles > a couple of nanoseconds faster. How did you do it :) ? I tried it with coccinelle but they have a problem handling compound literals :(. I opened a discussion on their mailing list hoping I will find a solution... https://systeme.lip6.fr/pipermail/cocci/2014-April/000794.html Thanks, Marcel > - once there, fixed the indentation of the .fields line, to a canonical > .fields = (VMStateField[]) [...]