From: Max Reitz <mreitz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Max Reitz <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH 0/4] qemu-img: Implement commit like QMP
Date: Mon, 7 Apr 2014 19:29:56 +0200 [thread overview]
Message-ID: <1396891800-8627-1-git-send-email-mreitz@redhat.com> (raw)
qemu-img should use QMP commands whenever possible in order to ensure
feature completeness of both online and offline image operations. For
the "commit" command, this is relatively easy, so implement it first
(in the hope that indeed others will follow).
As qemu-img does not have access to QMP (due to QMP being intertwined
with basically everything in qemu), we cannot directly use QMP, but at
least use the functions the corresponding QMP commands are using (which
would be "block-commit", in this case).
Max Reitz (4):
block-commit: Expose granularity
block-commit: speed is an optional parameter
qemu-img: Implement commit like QMP
qemu-img: Enable progress output for commit
block/Makefile.objs | 2 +-
block/commit.c | 16 ++++++--
block/mirror.c | 4 +-
blockdev.c | 22 +++++++---
include/block/block_int.h | 6 ++-
qapi-schema.json | 5 ++-
qemu-img-cmds.hx | 4 +-
qemu-img.c | 100 ++++++++++++++++++++++++++++++++++++----------
qemu-img.texi | 2 +-
9 files changed, 122 insertions(+), 39 deletions(-)
--
1.9.1
next reply other threads:[~2014-04-07 18:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-07 17:29 Max Reitz [this message]
2014-04-07 17:29 ` [Qemu-devel] [PATCH 1/4] block-commit: Expose granularity Max Reitz
2014-04-07 19:06 ` Eric Blake
2014-04-07 19:10 ` Max Reitz
2014-04-07 17:29 ` [Qemu-devel] [PATCH 2/4] block-commit: speed is an optional parameter Max Reitz
2014-04-07 18:55 ` Eric Blake
2014-04-07 18:56 ` Max Reitz
2014-04-07 17:29 ` [Qemu-devel] [PATCH 3/4] qemu-img: Implement commit like QMP Max Reitz
2014-04-07 19:10 ` Eric Blake
2014-04-07 19:28 ` Max Reitz
2014-04-08 6:49 ` Markus Armbruster
2014-04-08 11:16 ` Max Reitz
2014-04-07 17:30 ` [Qemu-devel] [PATCH 4/4] qemu-img: Enable progress output for commit Max Reitz
2014-04-07 20:06 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396891800-8627-1-git-send-email-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).