From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40566) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXpUd-0004Ex-TR for qemu-devel@nongnu.org; Wed, 09 Apr 2014 06:12:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WXpUX-0005xH-83 for qemu-devel@nongnu.org; Wed, 09 Apr 2014 06:12:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12104) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WXpUX-0005xB-0e for qemu-devel@nongnu.org; Wed, 09 Apr 2014 06:12:25 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s39ACMW0024938 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 9 Apr 2014 06:12:23 -0400 From: Kevin Wolf Date: Wed, 9 Apr 2014 11:20:09 +0200 Message-Id: <1397035209-14086-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH] bochs: Fix memory leak in bochs_open() error path List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com Signed-off-by: Kevin Wolf --- block/bochs.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/block/bochs.c b/block/bochs.c index 826ec12..50b84a9 100644 --- a/block/bochs.c +++ b/block/bochs.c @@ -150,11 +150,13 @@ static int bochs_open(BlockDriverState *bs, QDict *options, int flags, s->extent_size = le32_to_cpu(bochs.extent); if (s->extent_size == 0) { error_setg(errp, "Extent size may not be zero"); - return -EINVAL; + ret = -EINVAL; + goto fail; } else if (s->extent_size > 0x800000) { error_setg(errp, "Extent size %" PRIu32 " is too large", s->extent_size); - return -EINVAL; + ret = -EINVAL; + goto fail; } if (s->catalog_size < bs->total_sectors / s->extent_size) { -- 1.8.3.1