From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35786)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1WYDcg-0000z1-Vb
	for qemu-devel@nongnu.org; Thu, 10 Apr 2014 07:58:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1WYDcP-0007Un-BI
	for qemu-devel@nongnu.org; Thu, 10 Apr 2014 07:58:26 -0400
Received: from mx1.redhat.com ([209.132.183.28]:29902)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1WYDcP-0007Tx-2v
	for qemu-devel@nongnu.org; Thu, 10 Apr 2014 07:58:09 -0400
Message-ID: <1397131023.16790.98.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Thu, 10 Apr 2014 13:57:03 +0200
In-Reply-To: <20140410110502.GB19546@redhat.com>
References: <1397120874-17166-1-git-send-email-kraxel@redhat.com>
	<1397120874-17166-9-git-send-email-kraxel@redhat.com>
	<20140410110502.GB19546@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH qemu 6/6] virtio-input: evdev passthrough
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: virtio-dev@lists.oasis-open.org, qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>

  Hi,

> > +static void virtio_input_host_event(void *opaque)
> > +{
> > +    VirtIOInputHost *vhost = opaque;
> 
> I'd prefer a name that does not imply
> vhost infrastructure

ok.

> > +    rc = ioctl(vhost->fd, EVIOCGVERSION, &ver);
> > +    if (rc < 0) {
> > +        error_setg(errp, "%s: is not an evdev device", vhost->evdev);
> > +        goto err_close;
> > +    }
> 
> Hmm is that all?
> Don't we want to report versioning info to guests?

I guess the only thing we might want to here is bail out in case the
major version is != 1 (which implies a incompatible change).  The major
version didn't change so far though, and I think it is highly unlikely
that it'll ever happen.

cheers,
  Gerd