From: Kevin Wolf <kwolf@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org
Subject: [Qemu-devel] [PULL 3/4] iscsi: Remember to set ret for iscsi_open in error case
Date: Fri, 11 Apr 2014 14:39:11 +0200 [thread overview]
Message-ID: <1397219952-26807-4-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1397219952-26807-1-git-send-email-kwolf@redhat.com>
From: Fam Zheng <famz@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
block/iscsi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/iscsi.c b/block/iscsi.c
index 64a509f..f425573 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -1233,6 +1233,7 @@ static int iscsi_open(BlockDriverState *bs, QDict *options, int flags,
iscsi_readcapacity_sync(iscsilun, &local_err);
if (local_err != NULL) {
error_propagate(errp, local_err);
+ ret = -EINVAL;
goto out;
}
bs->total_sectors = sector_lun2qemu(iscsilun->num_blocks, iscsilun);
--
1.8.3.1
next prev parent reply other threads:[~2014-04-11 12:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-11 12:39 [Qemu-devel] [PULL 0/4] Block patches for 2.0.0-rc3 Kevin Wolf
2014-04-11 12:39 ` [Qemu-devel] [PULL 1/4] bochs: Fix memory leak in bochs_open() error path Kevin Wolf
2014-04-11 12:39 ` [Qemu-devel] [PULL 2/4] bochs: Fix catalog size check Kevin Wolf
2014-04-11 12:39 ` Kevin Wolf [this message]
2014-04-11 12:39 ` [Qemu-devel] [PULL 4/4] block-commit: speed is an optional parameter Kevin Wolf
2014-04-11 13:25 ` [Qemu-devel] [PULL 0/4] Block patches for 2.0.0-rc3 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397219952-26807-4-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).