From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34094) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WYajv-0003gm-Vb for qemu-devel@nongnu.org; Fri, 11 Apr 2014 08:39:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WYajp-00011t-Ll for qemu-devel@nongnu.org; Fri, 11 Apr 2014 08:39:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61743) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WYajp-00011n-E5 for qemu-devel@nongnu.org; Fri, 11 Apr 2014 08:39:21 -0400 From: Kevin Wolf Date: Fri, 11 Apr 2014 14:39:11 +0200 Message-Id: <1397219952-26807-4-git-send-email-kwolf@redhat.com> In-Reply-To: <1397219952-26807-1-git-send-email-kwolf@redhat.com> References: <1397219952-26807-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PULL 3/4] iscsi: Remember to set ret for iscsi_open in error case List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, peter.maydell@linaro.org From: Fam Zheng Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- block/iscsi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/iscsi.c b/block/iscsi.c index 64a509f..f425573 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -1233,6 +1233,7 @@ static int iscsi_open(BlockDriverState *bs, QDict *options, int flags, iscsi_readcapacity_sync(iscsilun, &local_err); if (local_err != NULL) { error_propagate(errp, local_err); + ret = -EINVAL; goto out; } bs->total_sectors = sector_lun2qemu(iscsilun->num_blocks, iscsilun); -- 1.8.3.1