From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39147) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WfsP2-0000to-Sd for qemu-devel@nongnu.org; Thu, 01 May 2014 10:56:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WfsOv-0004F0-9D for qemu-devel@nongnu.org; Thu, 01 May 2014 10:56:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6572) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WfsOv-0004Dm-0l for qemu-devel@nongnu.org; Thu, 01 May 2014 10:55:53 -0400 From: Stefan Hajnoczi Date: Thu, 1 May 2014 16:54:46 +0200 Message-Id: <1398956086-20171-23-git-send-email-stefanha@redhat.com> In-Reply-To: <1398956086-20171-1-git-send-email-stefanha@redhat.com> References: <1398956086-20171-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH 22/22] raw-posix: drop raw_get_aio_fd() since it is no longer used List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Paolo Bonzini , "Shergill, Gurinder" , "Vinod, Chegu" , Stefan Hajnoczi virtio-blk data-plane now uses the QEMU block layer for I/O. We do not need raw_get_aio_fd() anymore. It was a layering violation anyway, so let's get rid of it. Signed-off-by: Stefan Hajnoczi --- block/raw-posix.c | 34 ---------------------------------- include/block/block.h | 9 --------- 2 files changed, 43 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index 36366a6..17e5016 100644 --- a/block/raw-posix.c +++ b/block/raw-posix.c @@ -2301,40 +2301,6 @@ static BlockDriver bdrv_host_cdrom = { }; #endif /* __FreeBSD__ */ -#ifdef CONFIG_LINUX_AIO -/** - * Return the file descriptor for Linux AIO - * - * This function is a layering violation and should be removed when it becomes - * possible to call the block layer outside the global mutex. It allows the - * caller to hijack the file descriptor so I/O can be performed outside the - * block layer. - */ -int raw_get_aio_fd(BlockDriverState *bs) -{ - BDRVRawState *s; - - if (!bs->drv) { - return -ENOMEDIUM; - } - - if (bs->drv == bdrv_find_format("raw")) { - bs = bs->file; - } - - /* raw-posix has several protocols so just check for raw_aio_readv */ - if (bs->drv->bdrv_aio_readv != raw_aio_readv) { - return -ENOTSUP; - } - - s = bs->opaque; - if (!s->use_aio) { - return -ENOTSUP; - } - return s->fd; -} -#endif /* CONFIG_LINUX_AIO */ - static void bdrv_file_init(void) { /* diff --git a/include/block/block.h b/include/block/block.h index 5660184..15e88fd 100644 --- a/include/block/block.h +++ b/include/block/block.h @@ -448,15 +448,6 @@ void bdrv_unref(BlockDriverState *bs); void bdrv_set_in_use(BlockDriverState *bs, int in_use); int bdrv_in_use(BlockDriverState *bs); -#ifdef CONFIG_LINUX_AIO -int raw_get_aio_fd(BlockDriverState *bs); -#else -static inline int raw_get_aio_fd(BlockDriverState *bs) -{ - return -ENOTSUP; -} -#endif - enum BlockAcctType { BDRV_ACCT_READ, BDRV_ACCT_WRITE, -- 1.9.0