From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49908) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgBcF-0000pk-B1 for qemu-devel@nongnu.org; Fri, 02 May 2014 07:27:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WgBc8-0007WC-Uk for qemu-devel@nongnu.org; Fri, 02 May 2014 07:26:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44877) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgBc8-0007Vs-Me for qemu-devel@nongnu.org; Fri, 02 May 2014 07:26:48 -0400 From: Markus Armbruster Date: Fri, 2 May 2014 13:26:28 +0200 Message-Id: <1399030002-27222-1-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v3 00/14] qmp qga: Purge error_is_set() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, mdroth@linux.vnet.ibm.com, lcapitulino@redhat.com I got a private branch getting rid of it entirely. This is the fifth part, covering QMP and the guest agent up to the point where I start messing with the QAPI code generators. That's left for the final part. Luiz agreed to take this through his tree. This series conflicts with Llu=C3=ADs's "qapi: Allow modularization of QA= PI schema files", but only in docs/writing-qmp-commands.txt, and resolution is trivial. v3: - PATCH 02/15 peformed two unwanted renames, 03/15 reverted them; drop all that. Since this effectively squashes 03 into 02, I took the liberty to retain Eric's R-by. v2: - Rebased, straightforward conflict in PATCH 01/15 resolved - Commit message for PATCH 06/15 clarified [Eric] Markus Armbruster (14): qmp hmp: Consistently name Error * objects err, and not errp qga: Consistently name Error ** objects errp, and not err qmp: Consistently name Error ** objects errp, and not err error: Consistently name Error ** objects errp, and not err qga: Use return values instead of error_is_set(errp) hmp: Guard against misuse of hmp_handle_error() qapi: Drop redundant, unclean error_is_set() tests/qapi-schema: Drop superfluous error_is_set() qapi: Clean up fragile use of error_is_set() qga: Clean up fragile use of error_is_set() qga: Drop superfluous error_is_set() qemu-option: Clean up fragile use of error_is_set() dump: Drop pointless error_is_set(), DumpState member errp qmp: Don't use error_is_set() to suppress additional errors docs/writing-qmp-commands.txt | 28 ++--- dump.c | 6 +- hmp.c | 141 ++++++++++++------------ include/qapi/error.h | 27 +++-- include/qapi/qmp/dispatch.h | 2 +- qapi/qmp-dispatch.c | 24 ++--- qga/commands-posix.c | 213 ++++++++++++++++++++-----------= ------ qga/commands-win32.c | 123 ++++++++++----------- qga/commands.c | 4 +- qga/main.c | 1 + qga/vss-win32.c | 4 +- qga/vss-win32.h | 2 +- qmp.c | 42 +++----- tests/test-qmp-input-strict.c | 72 ++++++------- tests/test-qmp-input-visitor.c | 89 ++++++++-------- tests/test-qmp-output-visitor.c | 74 ++++++------- tests/test-string-input-visitor.c | 50 ++++----- tests/test-string-output-visitor.c | 46 ++++---- util/error.c | 8 +- util/qemu-option.c | 2 +- 20 files changed, 484 insertions(+), 474 deletions(-) --=20 1.8.1.4