From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50040) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgBcN-0000sM-KV for qemu-devel@nongnu.org; Fri, 02 May 2014 07:27:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WgBcB-0007Ww-AR for qemu-devel@nongnu.org; Fri, 02 May 2014 07:27:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49449) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WgBcB-0007Wh-3J for qemu-devel@nongnu.org; Fri, 02 May 2014 07:26:51 -0400 From: Markus Armbruster Date: Fri, 2 May 2014 13:26:34 +0200 Message-Id: <1399030002-27222-7-git-send-email-armbru@redhat.com> In-Reply-To: <1399030002-27222-1-git-send-email-armbru@redhat.com> References: <1399030002-27222-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH v3 06/14] hmp: Guard against misuse of hmp_handle_error() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, mdroth@linux.vnet.ibm.com, lcapitulino@redhat.com Null errp argument makes no sense. Assert it's not null, to make this explicit, and guard against misuse. All current callers pass non-null errp. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- hmp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hmp.c b/hmp.c index eb8ff41..ad31ceb 100644 --- a/hmp.c +++ b/hmp.c @@ -28,7 +28,8 @@ static void hmp_handle_error(Monitor *mon, Error **errp) { - if (error_is_set(errp)) { + assert(errp); + if (*errp) { monitor_printf(mon, "%s\n", error_get_pretty(*errp)); error_free(*errp); } -- 1.8.1.4