From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhGpL-00038f-PQ for qemu-devel@nongnu.org; Mon, 05 May 2014 07:13:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WhGpE-0005Kn-Cq for qemu-devel@nongnu.org; Mon, 05 May 2014 07:12:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10941) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WhGpE-0005KB-4S for qemu-devel@nongnu.org; Mon, 05 May 2014 07:12:48 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s45BCls3026606 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 5 May 2014 07:12:47 -0400 From: Gerd Hoffmann Date: Mon, 5 May 2014 13:12:37 +0200 Message-Id: <1399288360-29897-9-git-send-email-kraxel@redhat.com> In-Reply-To: <1399288360-29897-1-git-send-email-kraxel@redhat.com> References: <1399288360-29897-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PULL 08/10] usb: mtp: drop data-out hexdump List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann Signed-off-by: Gerd Hoffmann Reviewed-by: Peter Wu Reviewed-by: Stefan Hajnoczi --- hw/usb/dev-mtp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index a30a886..b6eaeae 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -1011,8 +1011,7 @@ static void usb_mtp_handle_data(USBDevice *dev, USBPacket *p) usb_mtp_command(s, &cmd); break; default: - iov_hexdump(p->iov.iov, p->iov.niov, stderr, "mtp-out", 32); - trace_usb_mtp_stall(s->dev.addr, "TODO: implement data-out"); + /* not needed as long as the mtp device is read-only */ p->status = USB_RET_STALL; return; } -- 1.8.3.1