qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robherring2@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Rob Herring <rob.herring@linaro.org>,
	qemu-devel@nongnu.org,
	Christoffer Dall <christoffer.dall@linaro.org>
Subject: [Qemu-devel] [PATCH 1/7] target-arm: use correct do_interrupt handler for AArch64 user mode
Date: Mon,  5 May 2014 11:00:17 -0500	[thread overview]
Message-ID: <1399305623-22016-2-git-send-email-robherring2@gmail.com> (raw)
In-Reply-To: <1399305623-22016-1-git-send-email-robherring2@gmail.com>

From: Rob Herring <rob.herring@linaro.org>

User mode emulation should never get interrupts and thus should not
use the system emulation exception handler function.

Signed-off-by: Rob Herring <rob.herring@linaro.org>
---
 target-arm/cpu64.c      | 4 ++++
 target-arm/helper-a64.c | 3 +++
 2 files changed, 7 insertions(+)

diff --git a/target-arm/cpu64.c b/target-arm/cpu64.c
index 8daa622..98d402f 100644
--- a/target-arm/cpu64.c
+++ b/target-arm/cpu64.c
@@ -187,7 +187,11 @@ static void aarch64_cpu_class_init(ObjectClass *oc, void *data)
 {
     CPUClass *cc = CPU_CLASS(oc);
 
+#if defined(CONFIG_USER_ONLY)
+    cc->do_interrupt = arm_cpu_do_interrupt;
+#else
     cc->do_interrupt = aarch64_cpu_do_interrupt;
+#endif
     cc->set_pc = aarch64_cpu_set_pc;
     cc->gdb_read_register = aarch64_cpu_gdb_read_register;
     cc->gdb_write_register = aarch64_cpu_gdb_write_register;
diff --git a/target-arm/helper-a64.c b/target-arm/helper-a64.c
index bf921cc..84411b4 100644
--- a/target-arm/helper-a64.c
+++ b/target-arm/helper-a64.c
@@ -438,6 +438,8 @@ float32 HELPER(fcvtx_f64_to_f32)(float64 a, CPUARMState *env)
     return r;
 }
 
+#if !defined(CONFIG_USER_ONLY)
+
 /* Handle a CPU exception.  */
 void aarch64_cpu_do_interrupt(CPUState *cs)
 {
@@ -512,3 +514,4 @@ void aarch64_cpu_do_interrupt(CPUState *cs)
     env->pc = addr;
     cs->interrupt_request |= CPU_INTERRUPT_EXITTB;
 }
+#endif
-- 
1.9.1

  reply	other threads:[~2014-05-05 16:00 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-05 16:00 [Qemu-devel] [PATCH 0/7] ARM: add PSCI enulation support Rob Herring
2014-05-05 16:00 ` Rob Herring [this message]
2014-05-05 16:15   ` [Qemu-devel] [PATCH 1/7] target-arm: use correct do_interrupt handler for AArch64 user mode Peter Maydell
2014-05-05 16:00 ` [Qemu-devel] [PATCH 2/7] target-arm: add powered off cpu state Rob Herring
2014-05-05 16:27   ` Peter Maydell
2014-05-15 13:12   ` Peter Crosthwaite
2014-05-05 16:00 ` [Qemu-devel] [PATCH 3/7] target-arm: add hvc and smc exception emulation handling infrastructure Rob Herring
2014-05-14 17:44   ` Peter Maydell
2014-05-14 20:55     ` Rob Herring
2014-05-15 13:06       ` Peter Maydell
2014-05-05 16:00 ` [Qemu-devel] [PATCH 4/7] target-arm: support AArch64 for arm_cpu_set_pc Rob Herring
2014-05-05 16:22   ` Peter Maydell
2014-05-05 16:00 ` [Qemu-devel] [PATCH 5/7] target-arm: add emulation of PSCI calls for system emulation Rob Herring
2014-05-14 18:12   ` Peter Maydell
2014-05-15  0:08     ` Rob Herring
2014-05-05 16:00 ` [Qemu-devel] [PATCH 6/7] arm/virt: enable PSCI emulation support " Rob Herring
2014-05-14 17:51   ` Peter Maydell
2014-05-14 19:15     ` Rob Herring
2014-05-14 21:25       ` Peter Maydell
2014-05-14 22:58         ` Rob Herring
2014-05-15  8:18           ` Peter Maydell
2014-05-05 16:00 ` [Qemu-devel] [PATCH 7/7] arm/highbank: enable PSCI emulation support Rob Herring
2014-05-15 13:07   ` Peter Crosthwaite

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1399305623-22016-2-git-send-email-robherring2@gmail.com \
    --to=robherring2@gmail.com \
    --cc=christoffer.dall@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rob.herring@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).