From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: "Andreas Färber" <afaerber@suse.de>,
"Anthony Liguori" <aliguori@amazon.com>,
"Marcel Apfelbaum" <marcel.a@redhat.com>
Subject: [Qemu-devel] [PULL 04/20] vl.c: Replace QEMUMachine with MachineClass in QEMUMachineInitArgs
Date: Mon, 5 May 2014 21:03:48 +0200 [thread overview]
Message-ID: <1399316644-20700-5-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1399316644-20700-1-git-send-email-afaerber@suse.de>
From: Marcel Apfelbaum <marcel.a@redhat.com>
QEMUMachine's fields are already in MachineClass. We can safely
make the switch because we copy them in machine_class_init() and
spapr_machine_class_init().
Signed-off-by: Marcel Apfelbaum <marcel.a@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
include/hw/boards.h | 5 +++--
vl.c | 2 +-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/include/hw/boards.h b/include/hw/boards.h
index c5f503d..be2e432 100644
--- a/include/hw/boards.h
+++ b/include/hw/boards.h
@@ -7,8 +7,10 @@
#include "hw/qdev.h"
#include "qom/object.h"
+typedef struct MachineClass MachineClass;
+
typedef struct QEMUMachineInitArgs {
- const QEMUMachine *machine;
+ const MachineClass *machine;
ram_addr_t ram_size;
const char *boot_order;
const char *kernel_filename;
@@ -62,7 +64,6 @@ int qemu_register_machine(QEMUMachine *m);
OBJECT_CLASS_CHECK(MachineClass, (klass), TYPE_MACHINE)
typedef struct MachineState MachineState;
-typedef struct MachineClass MachineClass;
MachineClass *find_default_machine(void);
extern MachineState *current_machine;
diff --git a/vl.c b/vl.c
index 3229c2f..2c2b625 100644
--- a/vl.c
+++ b/vl.c
@@ -4430,7 +4430,7 @@ int main(int argc, char **argv, char **envp)
qdev_machine_init();
current_machine->init_args = (QEMUMachineInitArgs) {
- .machine = machine,
+ .machine = machine_class,
.ram_size = ram_size,
.boot_order = boot_order,
.kernel_filename = kernel_filename,
--
1.8.4.5
next prev parent reply other threads:[~2014-05-05 19:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 19:03 [Qemu-devel] [PULL 00/20] QOM devices patch queue 2014-05-05 Andreas Färber
2014-05-05 19:03 ` [Qemu-devel] [PULL 01/20] qdev: Fix crash by validating the object type Andreas Färber
2014-05-05 19:03 ` [Qemu-devel] [PULL 02/20] machine: Remove obsoleted field from QEMUMachine Andreas Färber
2014-05-05 19:03 ` [Qemu-devel] [PULL 03/20] machine: Copy QEMUMachine's fields to MachineClass Andreas Färber
2014-05-05 19:03 ` Andreas Färber [this message]
2014-05-05 19:03 ` [Qemu-devel] [PULL 05/20] machine: Replace QEMUMachine by MachineClass in accelerator configuration Andreas Färber
2014-05-05 19:03 ` [Qemu-devel] [PULL 06/20] machine: Remove QEMUMachine indirection from MachineClass Andreas Färber
2014-05-05 19:03 ` [Qemu-devel] [PULL 07/20] hw: Consistently name Error * objects err, and not errp Andreas Färber
2014-05-05 19:03 ` [Qemu-devel] [PULL 08/20] hw: Consistently name Error ** objects errp, and not err Andreas Färber
2014-05-05 19:03 ` [Qemu-devel] [PULL 09/20] qom: Clean up fragile use of error_is_set() in set() methods Andreas Färber
2014-05-05 19:03 ` [Qemu-devel] [PULL 10/20] arm: Clean up fragile use of error_is_set() in realize() methods Andreas Färber
2014-05-05 19:03 ` [Qemu-devel] [PULL 11/20] MAINTAINERS: Document QOM Andreas Färber
2014-05-05 19:03 ` [Qemu-devel] [PULL 12/20] qtest: Assure that init_socket()'s listen() does not fail Andreas Färber
2014-05-05 19:03 ` [Qemu-devel] [PULL 13/20] qtest: Add error reporting to socket_accept() Andreas Färber
2014-05-05 19:03 ` [Qemu-devel] [PULL 14/20] qtest: Be paranoid about accept() addrlen argument Andreas Färber
2014-05-05 19:03 ` [Qemu-devel] [PULL 15/20] tests: Add ac97 qtest Andreas Färber
2014-05-05 19:04 ` [Qemu-devel] [PULL 16/20] tests: Add es1370 qtest Andreas Färber
2014-05-05 19:04 ` [Qemu-devel] [PULL 17/20] tests: Add intel-hda qtests Andreas Färber
2014-05-05 19:04 ` [Qemu-devel] [PULL 18/20] tests: Add ioh3420 qtest Andreas Färber
2014-05-05 19:04 ` [Qemu-devel] [PULL 19/20] tests: Add EHCI qtest Andreas Färber
2014-05-05 19:04 ` [Qemu-devel] [PULL 20/20] PortioList: Store PortioList in device state Andreas Färber
2014-05-07 13:53 ` [Qemu-devel] [PULL 00/20] QOM devices patch queue 2014-05-05 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399316644-20700-5-git-send-email-afaerber@suse.de \
--to=afaerber@suse.de \
--cc=aliguori@amazon.com \
--cc=marcel.a@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).