From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [PATCH 19/36] vmstate: s/VMSTATE_INT32_LE/VMSTATE_INT32_POSITIVE_LE/
Date: Mon, 5 May 2014 22:30:17 +0200 [thread overview]
Message-ID: <1399321834-31310-20-git-send-email-quintela@redhat.com> (raw)
In-Reply-To: <1399321834-31310-1-git-send-email-quintela@redhat.com>
From: "Michael S. Tsirkin" <mst@redhat.com>
As the macro verifies the value is positive, rename it
to make the function clearer.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
hw/pci/pci.c | 4 ++--
include/migration/vmstate.h | 2 +-
target-arm/machine.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index 2a9f08e..517ff2a 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -475,7 +475,7 @@ const VMStateDescription vmstate_pci_device = {
.minimum_version_id = 1,
.minimum_version_id_old = 1,
.fields = (VMStateField []) {
- VMSTATE_INT32_LE(version_id, PCIDevice),
+ VMSTATE_INT32_POSITIVE_LE(version_id, PCIDevice),
VMSTATE_BUFFER_UNSAFE_INFO(config, PCIDevice, 0,
vmstate_info_pci_config,
PCI_CONFIG_SPACE_SIZE),
@@ -492,7 +492,7 @@ const VMStateDescription vmstate_pcie_device = {
.minimum_version_id = 1,
.minimum_version_id_old = 1,
.fields = (VMStateField []) {
- VMSTATE_INT32_LE(version_id, PCIDevice),
+ VMSTATE_INT32_POSITIVE_LE(version_id, PCIDevice),
VMSTATE_BUFFER_UNSAFE_INFO(config, PCIDevice, 0,
vmstate_info_pci_config,
PCIE_CONFIG_SPACE_SIZE),
diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
index 5b71370..7e45048 100644
--- a/include/migration/vmstate.h
+++ b/include/migration/vmstate.h
@@ -601,7 +601,7 @@ extern const VMStateInfo vmstate_info_bitmap;
#define VMSTATE_UINT64_EQUAL(_f, _s) \
VMSTATE_UINT64_EQUAL_V(_f, _s, 0)
-#define VMSTATE_INT32_LE(_f, _s) \
+#define VMSTATE_INT32_POSITIVE_LE(_f, _s) \
VMSTATE_SINGLE(_f, _s, 0, vmstate_info_int32_le, int32_t)
#define VMSTATE_UINT8_TEST(_f, _s, _t) \
diff --git a/target-arm/machine.c b/target-arm/machine.c
index b967223..810ba27 100644
--- a/target-arm/machine.c
+++ b/target-arm/machine.c
@@ -248,7 +248,7 @@ const VMStateDescription vmstate_arm_cpu = {
/* The length-check must come before the arrays to avoid
* incoming data possibly overflowing the array.
*/
- VMSTATE_INT32_LE(cpreg_vmstate_array_len, ARMCPU),
+ VMSTATE_INT32_POSITIVE_LE(cpreg_vmstate_array_len, ARMCPU),
VMSTATE_VARRAY_INT32(cpreg_vmstate_indexes, ARMCPU,
cpreg_vmstate_array_len,
0, vmstate_info_uint64, uint64_t),
--
1.9.0
next prev parent reply other threads:[~2014-05-05 20:31 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 20:29 [Qemu-devel] [PULL 00/36] migration queue Juan Quintela
2014-05-05 20:29 ` [Qemu-devel] [PATCH 01/36] vmstate: reduce code duplication Juan Quintela
2014-05-05 20:30 ` [Qemu-devel] [PATCH 02/36] vmstate: add VMS_MUST_EXIST Juan Quintela
2014-05-05 20:30 ` [Qemu-devel] [PATCH 03/36] vmstate: add VMSTATE_VALIDATE Juan Quintela
2014-05-05 20:30 ` [Qemu-devel] [PATCH 04/36] virtio-net: fix buffer overflow on invalid state load Juan Quintela
2014-05-05 20:30 ` [Qemu-devel] [PATCH 05/36] virtio-net: out-of-bounds buffer write " Juan Quintela
2014-05-05 20:30 ` [Qemu-devel] [PATCH 06/36] virtio: " Juan Quintela
2014-05-05 20:30 ` [Qemu-devel] [PATCH 07/36] ahci: fix buffer overrun " Juan Quintela
2014-05-05 20:30 ` [Qemu-devel] [PATCH 08/36] hpet: " Juan Quintela
2014-05-05 20:30 ` [Qemu-devel] [PATCH 09/36] hw/pci/pcie_aer.c: fix buffer overruns " Juan Quintela
2014-05-05 20:30 ` [Qemu-devel] [PATCH 10/36] pl022: fix buffer overun " Juan Quintela
2014-05-05 20:30 ` [Qemu-devel] [PATCH 11/36] vmstate: fix buffer overflow in target-arm/machine.c Juan Quintela
2014-05-05 20:30 ` [Qemu-devel] [PATCH 12/36] virtio: avoid buffer overrun on incoming migration Juan Quintela
2014-05-05 20:30 ` [Qemu-devel] [PATCH 13/36] virtio: validate num_sg when mapping Juan Quintela
2014-05-05 20:30 ` [Qemu-devel] [PATCH 14/36] pxa2xx: avoid buffer overrun on incoming migration Juan Quintela
2014-05-05 20:30 ` [Qemu-devel] [PATCH 15/36] ssd0323: fix buffer overun on invalid state load Juan Quintela
2014-05-05 20:30 ` [Qemu-devel] [PATCH 16/36] tsc210x: fix buffer overrun " Juan Quintela
2014-05-05 20:30 ` [Qemu-devel] [PATCH 17/36] zaurus: " Juan Quintela
2014-05-05 20:30 ` [Qemu-devel] [PATCH 18/36] virtio-scsi: " Juan Quintela
2014-05-05 20:30 ` Juan Quintela [this message]
2014-05-05 20:30 ` [Qemu-devel] [PATCH 20/36] usb: sanity check setup_index+setup_len in post_load Juan Quintela
2014-05-05 20:30 ` [Qemu-devel] [PATCH 21/36] savevm: Ignore minimum_version_id_old if there is no load_state_old Juan Quintela
2014-05-05 20:30 ` [Qemu-devel] [PATCH 22/36] ssi-sd: fix buffer overrun on invalid state load Juan Quintela
2014-05-05 20:30 ` [Qemu-devel] [PATCH 23/36] openpic: avoid buffer overrun on incoming migration Juan Quintela
2014-05-05 20:30 ` [Qemu-devel] [PATCH 24/36] virtio-net: out-of-bounds buffer write on load Juan Quintela
2014-05-05 20:30 ` [Qemu-devel] [PATCH 25/36] virtio: validate config_len " Juan Quintela
2014-05-05 20:30 ` [Qemu-devel] [PATCH 26/36] Disallow outward migration while awaiting incoming migration Juan Quintela
2014-05-05 20:30 ` [Qemu-devel] [PATCH 27/36] Make qemu_peek_buffer loop until it gets it's data Juan Quintela
2014-05-05 20:30 ` [Qemu-devel] [PATCH 28/36] Count used RAMBlock pages for migration_dirty_pages Juan Quintela
2014-05-05 20:30 ` [Qemu-devel] [PATCH 29/36] Provide init function for ram migration Juan Quintela
2014-05-05 20:30 ` [Qemu-devel] [PATCH 30/36] Init the XBZRLE.lock in ram_mig_init Juan Quintela
2014-05-05 20:30 ` [Qemu-devel] [PATCH 31/36] Coverity: Fix failure path for qemu_accept in migration Juan Quintela
2014-05-05 20:30 ` [Qemu-devel] [PATCH 32/36] migration: remove duplicate code Juan Quintela
2014-05-05 20:30 ` [Qemu-devel] [PATCH 33/36] XBZRLE: Fix one XBZRLE corruption issues Juan Quintela
2014-05-05 20:30 ` [Qemu-devel] [PATCH 34/36] migration: Add counts of updating the dirty bitmap Juan Quintela
2014-05-05 20:30 ` [Qemu-devel] [PATCH 35/36] migration: expose the bitmap_sync_count to the end Juan Quintela
2014-05-05 20:30 ` [Qemu-devel] [PATCH 36/36] migration: expose xbzrle cache miss rate Juan Quintela
2014-05-07 15:09 ` [Qemu-devel] [PULL 00/36] migration queue Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399321834-31310-20-git-send-email-quintela@redhat.com \
--to=quintela@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).