qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: qemu-devel@nongnu.org, peter.maydell@linaro.org
Cc: rob.herring@linaro.org, peter.crosthwaite@xilinx.com,
	john.williams@xilinx.com, alex.bennee@linaro.org, agraf@suse.de
Subject: [Qemu-devel] [PATCH v1 10/22] target-arm: A64: Introduce arm64_banked_spsr_index()
Date: Tue,  6 May 2014 16:08:14 +1000	[thread overview]
Message-ID: <1399356506-5609-11-git-send-email-edgar.iglesias@gmail.com> (raw)
In-Reply-To: <1399356506-5609-1-git-send-email-edgar.iglesias@gmail.com>

From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>

Add arm64_banked_spsr_index(), used to map an Exception Level
to an index in the baked_spsr array.

Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
---
 target-arm/helper-a64.c |  5 +++--
 target-arm/internals.h  | 14 ++++++++++++++
 target-arm/op_helper.c  |  3 ++-
 3 files changed, 19 insertions(+), 3 deletions(-)

diff --git a/target-arm/helper-a64.c b/target-arm/helper-a64.c
index 10bd1fc..415efbe 100644
--- a/target-arm/helper-a64.c
+++ b/target-arm/helper-a64.c
@@ -444,6 +444,7 @@ void aarch64_cpu_do_interrupt(CPUState *cs)
     ARMCPU *cpu = ARM_CPU(cs);
     CPUARMState *env = &cpu->env;
     target_ulong addr = env->cp15.vbar_el[VBAR_EL_IDX(1)];
+    unsigned int spsr_idx = arm64_banked_spsr_index(1);
     int i;
 
     if (arm_current_pl(env) == 0) {
@@ -488,12 +489,12 @@ void aarch64_cpu_do_interrupt(CPUState *cs)
     }
 
     if (is_a64(env)) {
-        env->banked_spsr[0] = pstate_read(env);
+        env->banked_spsr[spsr_idx] = pstate_read(env);
         env->sp_el[arm_current_pl(env)] = env->xregs[31];
         env->xregs[31] = env->sp_el[1];
         env->elr_el[ELR_EL_IDX(1)] = env->pc;
     } else {
-        env->banked_spsr[0] = cpsr_read(env);
+        env->banked_spsr[spsr_idx] = cpsr_read(env);
         if (!env->thumb) {
             env->cp15.esr_el[ESR_EL_IDX(1)] |= 1 << 25;
         }
diff --git a/target-arm/internals.h b/target-arm/internals.h
index d63a975..7c39946 100644
--- a/target-arm/internals.h
+++ b/target-arm/internals.h
@@ -75,6 +75,20 @@ static inline void arm_log_exception(int idx)
  */
 #define GTIMER_SCALE 16
 
+/*
+ * For aarch64, map a given EL to an index in the banked_spsr array.
+ */
+static inline unsigned int arm64_banked_spsr_index(unsigned int el)
+{
+    static const unsigned int map[3] = {
+        [0] = 0, /* EL1.  */
+        [1] = 6, /* EL2.  */
+        [2] = 7, /* EL3.  */
+    };
+    assert(el >= 1 && el <= 3);
+    return map[el - 1];
+}
+
 int bank_number(int mode);
 void switch_mode(CPUARMState *, int);
 void arm_cpu_register_gdb_regs_for_features(ARMCPU *cpu);
diff --git a/target-arm/op_helper.c b/target-arm/op_helper.c
index 21545d0..dd9e4fc 100644
--- a/target-arm/op_helper.c
+++ b/target-arm/op_helper.c
@@ -386,7 +386,8 @@ void HELPER(msr_i_pstate)(CPUARMState *env, uint32_t op, uint32_t imm)
 
 void HELPER(exception_return)(CPUARMState *env)
 {
-    uint32_t spsr = env->banked_spsr[0];
+    unsigned int spsr_idx = arm64_banked_spsr_index(1);
+    uint32_t spsr = env->banked_spsr[spsr_idx];
     int new_el, i;
 
     if (env->pstate & PSTATE_SP) {
-- 
1.8.3.2

  parent reply	other threads:[~2014-05-06  6:15 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-06  6:08 [Qemu-devel] [PATCH v1 00/22] target-arm: Preparations for A64 EL2 and 3 Edgar E. Iglesias
2014-05-06  6:08 ` [Qemu-devel] [PATCH v1 01/22] target-arm: A64: Add friendly logging of PSTATE A and I flags Edgar E. Iglesias
2014-05-07  5:32   ` Peter Crosthwaite
2014-05-07  8:50   ` Peter Maydell
2014-05-08  0:08     ` Edgar E. Iglesias
2014-05-06  6:08 ` [Qemu-devel] [PATCH v1 02/22] target-arm: Make elr_el1 an array Edgar E. Iglesias
2014-05-07  5:10   ` Peter Crosthwaite
2014-05-08  0:13     ` Edgar E. Iglesias
2014-05-16 14:19       ` Peter Maydell
2014-05-16 22:19         ` Edgar E. Iglesias
2014-05-16 14:22   ` Peter Maydell
2014-05-16 22:18     ` Edgar E. Iglesias
2014-05-06  6:08 ` [Qemu-devel] [PATCH v1 03/22] target-arm: Make esr_el1 " Edgar E. Iglesias
2014-05-06  6:08 ` [Qemu-devel] [PATCH v1 04/22] target-arm: c12_vbar -> vbar_el[] Edgar E. Iglesias
2014-05-06  6:08 ` [Qemu-devel] [PATCH v1 05/22] target-arm: Add arm_el_to_mmu_idx() Edgar E. Iglesias
2014-05-07  5:43   ` Peter Crosthwaite
2014-05-16 14:24   ` Peter Maydell
2014-05-16 22:10     ` Edgar E. Iglesias
2014-05-16 22:13       ` Alexander Graf
2014-05-17  1:41         ` Edgar E. Iglesias
2014-05-06  6:08 ` [Qemu-devel] [PATCH v1 06/22] target-arm: Move get_mem_index to translate.h Edgar E. Iglesias
2014-05-06  6:08 ` [Qemu-devel] [PATCH v1 07/22] target-arm: A64: Add SP entries for EL2 and 3 Edgar E. Iglesias
2014-05-06  6:08 ` [Qemu-devel] [PATCH v1 08/22] target-arm: A64: Add ELR " Edgar E. Iglesias
2014-05-06  6:08 ` [Qemu-devel] [PATCH v1 09/22] target-arm: Add SPSR entries for EL2/HYP and EL3/MON Edgar E. Iglesias
2014-05-07  5:31   ` Edgar E. Iglesias
2014-05-06  6:08 ` Edgar E. Iglesias [this message]
2014-05-07  5:50   ` [Qemu-devel] [PATCH v1 10/22] target-arm: A64: Introduce arm64_banked_spsr_index() Peter Crosthwaite
2014-05-16 14:31   ` Peter Maydell
2014-05-17  2:21     ` Edgar E. Iglesias
2014-05-06  6:08 ` [Qemu-devel] [PATCH v1 11/22] target-arm: Add a feature flag for EL2 Edgar E. Iglesias
2014-05-07  5:50   ` Peter Crosthwaite
2014-05-06  6:08 ` [Qemu-devel] [PATCH v1 12/22] target-arm: Add a feature flag for EL3 Edgar E. Iglesias
2014-05-07  5:51   ` Peter Crosthwaite
2014-05-06  6:08 ` [Qemu-devel] [PATCH v1 13/22] target-arm: Register EL2 versions of ELR and SPSR Edgar E. Iglesias
2014-05-07  6:02   ` Peter Crosthwaite
2014-05-16 14:36     ` Peter Maydell
2014-05-06  6:08 ` [Qemu-devel] [PATCH v1 14/22] target-arm: Register EL3 " Edgar E. Iglesias
2014-05-07  6:02   ` Peter Crosthwaite
2014-05-06  6:08 ` [Qemu-devel] [PATCH v1 15/22] target-arm: A64: Forbid ERET to increase the EL Edgar E. Iglesias
2014-05-07  6:03   ` Peter Crosthwaite
2014-05-06  6:08 ` [Qemu-devel] [PATCH v1 16/22] target-arm: A64: Forbid ERET to unimplemented ELs Edgar E. Iglesias
2014-05-07  6:04   ` Peter Crosthwaite
2014-05-07  9:00   ` Peter Maydell
2014-05-08  0:14     ` Edgar E. Iglesias
2014-05-06  6:08 ` [Qemu-devel] [PATCH v1 17/22] target-arm: A64: Generalize ERET to various ELs Edgar E. Iglesias
2014-05-07  6:09   ` Peter Crosthwaite
2014-05-06  6:08 ` [Qemu-devel] [PATCH v1 18/22] target-arm: A64: Generalize update_spsel for the " Edgar E. Iglesias
2014-05-07  6:13   ` Peter Crosthwaite
2014-05-13 17:32   ` Richard Henderson
2014-05-14  1:18     ` Edgar E. Iglesias
2014-05-14 15:57       ` Richard Henderson
2014-05-06  6:08 ` [Qemu-devel] [PATCH v1 19/22] target-arm: Add storage for VBAR_EL2 and 3 Edgar E. Iglesias
2014-05-16 14:40   ` Peter Maydell
2014-05-17  1:42     ` Edgar E. Iglesias
2014-05-06  6:08 ` [Qemu-devel] [PATCH v1 20/22] target-arm: Make vbar_write writeback to any CPREG Edgar E. Iglesias
2014-05-07  6:19   ` Peter Crosthwaite
2014-05-06  6:08 ` [Qemu-devel] [PATCH v1 21/22] target-arm: A64: Register VBAR_EL2 Edgar E. Iglesias
2014-05-07  6:22   ` Peter Crosthwaite
2014-05-16 14:43   ` Peter Maydell
2014-05-06  6:08 ` [Qemu-devel] [PATCH v1 22/22] target-arm: A64: Register VBAR_EL3 Edgar E. Iglesias
2014-05-07  6:23   ` Peter Crosthwaite
2014-05-06  7:58 ` [Qemu-devel] [PATCH v1 00/22] target-arm: Preparations for A64 EL2 and 3 Peter Maydell
2014-05-07  3:46   ` Edgar E. Iglesias
2014-05-12 19:13     ` Aggeler  Fabian
2014-05-12 20:39       ` Peter Maydell
2014-05-14  8:58         ` Aggeler  Fabian
2014-05-14 13:55           ` Greg Bellows
2014-05-15  9:28             ` Aggeler  Fabian
2014-05-15  9:45               ` Sergey Fedorov
2014-05-15 12:44                 ` Christopher Covington
2014-05-14 14:56           ` Edgar E. Iglesias
2014-05-12 23:41       ` Peter Crosthwaite
2014-05-13  3:31       ` Edgar E. Iglesias
2014-05-06  8:24 ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1399356506-5609-11-git-send-email-edgar.iglesias@gmail.com \
    --to=edgar.iglesias@gmail.com \
    --cc=agraf@suse.de \
    --cc=alex.bennee@linaro.org \
    --cc=john.williams@xilinx.com \
    --cc=peter.crosthwaite@xilinx.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rob.herring@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).