From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41072) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Whf6z-00037Q-J0 for qemu-devel@nongnu.org; Tue, 06 May 2014 09:08:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Whf6t-00077Y-F0 for qemu-devel@nongnu.org; Tue, 06 May 2014 09:08:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8843) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Whf6t-00077S-6W for qemu-devel@nongnu.org; Tue, 06 May 2014 09:08:39 -0400 From: Fam Zheng Date: Tue, 6 May 2014 21:08:43 +0800 Message-Id: <1399381726-8078-2-git-send-email-famz@redhat.com> In-Reply-To: <1399381726-8078-1-git-send-email-famz@redhat.com> References: <1399381726-8078-1-git-send-email-famz@redhat.com> Subject: [Qemu-devel] [PATCH v4 1/4] qemu-img: Convert by cluster size if target is compressed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, gentoo.integer@gmail.com, stefanha@redhat.com If target block driver forces compression, qemu-img convert needs to write by cluster size as well as "-c" option. Particularly, this applies for converting to VMDK streamOptimized format. Signed-off-by: Fam Zheng --- include/block/block.h | 4 ++++ qemu-img.c | 1 + 2 files changed, 5 insertions(+) diff --git a/include/block/block.h b/include/block/block.h index 467fb2b..27d8598 100644 --- a/include/block/block.h +++ b/include/block/block.h @@ -34,6 +34,10 @@ typedef struct BlockDriverInfo { * opened with BDRV_O_UNMAP flag for this to work. */ bool can_write_zeroes_with_unmap; + /* + * True if this block driver only supports compressed writes + */ + bool needs_compressed_writes; } BlockDriverInfo; typedef struct BlockFragInfo { diff --git a/qemu-img.c b/qemu-img.c index 96f4463..ed4471b 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -1480,6 +1480,7 @@ static int img_convert(int argc, char **argv) goto out; } } else { + compress = compress || bdi.needs_compressed_writes; cluster_sectors = bdi.cluster_size / BDRV_SECTOR_SIZE; } -- 1.9.2