* [Qemu-devel] [PATCH] qmp: use valid JSON in transaction example
@ 2014-05-06 15:39 Eric Blake
2014-05-07 14:37 ` Luiz Capitulino
0 siblings, 1 reply; 2+ messages in thread
From: Eric Blake @ 2014-05-06 15:39 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, lcapitulino
Our example should use the correct quotes to match what someone
could actually pass over the wire.
* qmp-commands.hx: Use correct JSON quotes.
Signed-off-by: Eric Blake <eblake@redhat.com>
---
qmp-commands.hx | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/qmp-commands.hx b/qmp-commands.hx
index ed3ab92..e20fcf0 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -1165,19 +1165,19 @@ Example:
-> { "execute": "transaction",
"arguments": { "actions": [
- { 'type': 'blockdev-snapshot-sync', 'data' : { "device": "ide-hd0",
+ { "type": "blockdev-snapshot-sync", "data" : { "device": "ide-hd0",
"snapshot-file": "/some/place/my-image",
"format": "qcow2" } },
- { 'type': 'blockdev-snapshot-sync', 'data' : { "node-name": "myfile",
+ { "type": "blockdev-snapshot-sync", "data" : { "node-name": "myfile",
"snapshot-file": "/some/place/my-image2",
"snapshot-node-name": "node3432",
"mode": "existing",
"format": "qcow2" } },
- { 'type': 'blockdev-snapshot-sync', 'data' : { "device": "ide-hd1",
+ { "type": "blockdev-snapshot-sync", "data" : { "device": "ide-hd1",
"snapshot-file": "/some/place/my-image2",
"mode": "existing",
"format": "qcow2" } },
- { 'type': 'blockdev-snapshot-internal-sync', 'data' : {
+ { "type": "blockdev-snapshot-internal-sync", "data" : {
"device": "ide-hd2",
"name": "snapshot0" } } ] } }
<- { "return": {} }
--
1.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] qmp: use valid JSON in transaction example
2014-05-06 15:39 [Qemu-devel] [PATCH] qmp: use valid JSON in transaction example Eric Blake
@ 2014-05-07 14:37 ` Luiz Capitulino
0 siblings, 0 replies; 2+ messages in thread
From: Luiz Capitulino @ 2014-05-07 14:37 UTC (permalink / raw)
To: Eric Blake; +Cc: qemu-trivial, qemu-devel
On Tue, 6 May 2014 09:39:03 -0600
Eric Blake <eblake@redhat.com> wrote:
> Our example should use the correct quotes to match what someone
> could actually pass over the wire.
>
> * qmp-commands.hx: Use correct JSON quotes.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
Applied to the qmp branch, thanks.
> ---
> qmp-commands.hx | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/qmp-commands.hx b/qmp-commands.hx
> index ed3ab92..e20fcf0 100644
> --- a/qmp-commands.hx
> +++ b/qmp-commands.hx
> @@ -1165,19 +1165,19 @@ Example:
>
> -> { "execute": "transaction",
> "arguments": { "actions": [
> - { 'type': 'blockdev-snapshot-sync', 'data' : { "device": "ide-hd0",
> + { "type": "blockdev-snapshot-sync", "data" : { "device": "ide-hd0",
> "snapshot-file": "/some/place/my-image",
> "format": "qcow2" } },
> - { 'type': 'blockdev-snapshot-sync', 'data' : { "node-name": "myfile",
> + { "type": "blockdev-snapshot-sync", "data" : { "node-name": "myfile",
> "snapshot-file": "/some/place/my-image2",
> "snapshot-node-name": "node3432",
> "mode": "existing",
> "format": "qcow2" } },
> - { 'type': 'blockdev-snapshot-sync', 'data' : { "device": "ide-hd1",
> + { "type": "blockdev-snapshot-sync", "data" : { "device": "ide-hd1",
> "snapshot-file": "/some/place/my-image2",
> "mode": "existing",
> "format": "qcow2" } },
> - { 'type': 'blockdev-snapshot-internal-sync', 'data' : {
> + { "type": "blockdev-snapshot-internal-sync", "data" : {
> "device": "ide-hd2",
> "name": "snapshot0" } } ] } }
> <- { "return": {} }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-07 14:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-06 15:39 [Qemu-devel] [PATCH] qmp: use valid JSON in transaction example Eric Blake
2014-05-07 14:37 ` Luiz Capitulino
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).