From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48862) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Whwg2-00029a-SK for qemu-devel@nongnu.org; Wed, 07 May 2014 03:54:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Whwfx-0006fM-RJ for qemu-devel@nongnu.org; Wed, 07 May 2014 03:54:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64552) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Whwfx-0006en-IF for qemu-devel@nongnu.org; Wed, 07 May 2014 03:54:01 -0400 From: Markus Armbruster Date: Wed, 7 May 2014 09:53:42 +0200 Message-Id: <1399449234-28501-1-git-send-email-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v2 00/12] qapi: Purge error_is_set() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com, lcapitulino@redhat.com, pbonzini@redhat.com, akong@redhat.com, vilanova@ac.upc.edu This is the sixth part, covering QAPI and its users. Luiz agreed to take this through his tree. PATCH 01-08 are preparatory cleanups. PATCH 09-11 fix misuses of the visitor API in hand-written code. Generated code uses the API correctly. PATCH 12 converts QAPI and its users to the common use of the error API, purging error_is_set() along the way. v1 has a PATCH 13 that drops error_is_set(). This depends on all five prior parts of the purge, of which only the first two have been committed already. Luiz asked me to drop it from this series. My series conflicts with Llu=C3=ADs's "qapi: Allow modularization of QAPI schema files" and Amos's "qapi: fix coding style in generated code", but the conflicts are trivial, and 3-way merge can take care of them. v2: * Fix pasto in commit messages of PATCH 10+11 [Eric] * Fix logic error in PATCH 12 [Eric] * Update copyright notice in PATCH 12 * Unbundle PATCH 13 Markus Armbruster (12): qapi: Update qapi-code-gen.txt example to match current code qapi: Normalize marshalling's visitor initialization and cleanup qapi: Remove unused Visitor callbacks start_handle(), end_handle() qapi: Replace start_optional()/end_optional() by optional() qapi-visit.py: Clean up confusing push_indent() / pop_indent() use qapi: Clean up shadowing of parameters and locals in inner scopes qapi-visit.py: Clean up a sloppy use of field prefix qapi: Un-inline visit of implicit struct hmp: Call visit_end_struct() after visit_start_struct() succeeds hw: Don't call visit_end_struct() after visit_start_struct() fails tests: Don't call visit_end_struct() after visit_start_struct() fails qapi: Replace uncommon use of the error API by the common one docs/qapi-code-gen.txt | 165 ++++++++++++++--------- hmp.c | 16 +-- hw/timer/mc146818rtc.c | 41 +++++- hw/virtio/virtio-balloon.c | 33 +++-- include/qapi/visitor-impl.h | 8 +- include/qapi/visitor.h | 5 +- qapi/opts-visitor.c | 5 +- qapi/qapi-visit-core.c | 259 +++++++++++++++----------------= ------ qapi/qmp-input-visitor.c | 6 +- qapi/string-input-visitor.c | 6 +- scripts/qapi-commands.py | 89 ++++++++----- scripts/qapi-visit.py | 232 +++++++++++++++++++------------= -- tests/test-qmp-input-strict.c | 28 +++- tests/test-qmp-input-visitor.c | 26 ++-- tests/test-qmp-output-visitor.c | 28 +++- tests/test-visitor-serialization.c | 26 +++- 16 files changed, 558 insertions(+), 415 deletions(-) --=20 1.8.1.4