From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48968) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Whwg9-0002AC-C3 for qemu-devel@nongnu.org; Wed, 07 May 2014 03:54:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Whwg3-0006hi-T2 for qemu-devel@nongnu.org; Wed, 07 May 2014 03:54:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18639) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Whwg3-0006hQ-LA for qemu-devel@nongnu.org; Wed, 07 May 2014 03:54:07 -0400 From: Markus Armbruster Date: Wed, 7 May 2014 09:53:49 +0200 Message-Id: <1399449234-28501-8-git-send-email-armbru@redhat.com> In-Reply-To: <1399449234-28501-1-git-send-email-armbru@redhat.com> References: <1399449234-28501-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH v2 07/12] qapi-visit.py: Clean up a sloppy use of field prefix List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: mdroth@linux.vnet.ibm.com, lcapitulino@redhat.com, pbonzini@redhat.com, akong@redhat.com, vilanova@ac.upc.edu generate_visit_struct_fields() generates the base type's struct member name both with and without the field prefix. Harmless, because the field prefix is always empty there: only unboxed complex members have a prefix, and those can't have a base type. Clean it up anyway. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- scripts/qapi-visit.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py index 222ce62..23ae5f2 100644 --- a/scripts/qapi-visit.py +++ b/scripts/qapi-visit.py @@ -60,7 +60,7 @@ static void visit_type_%(full_name)s_fields(Visitor *m, %(name)s ** obj, Error * if base: ret += mcgen(''' -visit_start_implicit_struct(m, (void**) &(*obj)->%(c_name)s, sizeof(%(type)s), &err); +visit_start_implicit_struct(m, (void**) &(*obj)->%(c_prefix)s%(c_name)s, sizeof(%(type)s), &err); if (!err) { visit_type_%(type)s_fields(m, &(*obj)->%(c_prefix)s%(c_name)s, &err); error_propagate(errp, err); -- 1.8.1.4