qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Chunyan Liu <cyliu@suse.com>
To: qemu-devel@nongnu.org
Cc: l@dorileo.org, stefanha@redhat.com
Subject: [Qemu-devel] [PATCH v27 01/33] QemuOpts: move find_desc_by_name ahead for later calling
Date: Wed,  7 May 2014 17:54:04 +0800	[thread overview]
Message-ID: <1399456476-10786-2-git-send-email-cyliu@suse.com> (raw)
In-Reply-To: <1399456476-10786-1-git-send-email-cyliu@suse.com>

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Chunyan Liu <cyliu@suse.com>
---
 util/qemu-option.c | 28 ++++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/util/qemu-option.c b/util/qemu-option.c
index 8bbc3ad..808aef4 100644
--- a/util/qemu-option.c
+++ b/util/qemu-option.c
@@ -173,6 +173,20 @@ static void parse_option_number(const char *name, const char *value,
     }
 }
 
+static const QemuOptDesc *find_desc_by_name(const QemuOptDesc *desc,
+                                            const char *name)
+{
+    int i;
+
+    for (i = 0; desc[i].name != NULL; i++) {
+        if (strcmp(desc[i].name, name) == 0) {
+            return &desc[i];
+        }
+    }
+
+    return NULL;
+}
+
 void parse_option_size(const char *name, const char *value,
                        uint64_t *ret, Error **errp)
 {
@@ -637,20 +651,6 @@ static bool opts_accepts_any(const QemuOpts *opts)
     return opts->list->desc[0].name == NULL;
 }
 
-static const QemuOptDesc *find_desc_by_name(const QemuOptDesc *desc,
-                                            const char *name)
-{
-    int i;
-
-    for (i = 0; desc[i].name != NULL; i++) {
-        if (strcmp(desc[i].name, name) == 0) {
-            return &desc[i];
-        }
-    }
-
-    return NULL;
-}
-
 int qemu_opt_unset(QemuOpts *opts, const char *name)
 {
     QemuOpt *opt = qemu_opt_find(opts, name);
-- 
1.7.12.4

  reply	other threads:[~2014-05-07  9:55 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-07  9:54 [Qemu-devel] [PATCH v27 00/33] replace QEMUOptionParameter with QemuOpts Chunyan Liu
2014-05-07  9:54 ` Chunyan Liu [this message]
2014-05-07  9:54 ` [Qemu-devel] [PATCH v27 02/33] QemuOpts: repurpose qemu_opts_print to replace print_option_parameters Chunyan Liu
2014-05-07  9:54 ` [Qemu-devel] [PATCH v27 03/33] QemuOpts: add def_value_str to QemuOptDesc Chunyan Liu
2014-05-07  9:54 ` [Qemu-devel] [PATCH v27 04/33] qapi: output def_value_str when query command line options Chunyan Liu
2014-05-07  9:54 ` [Qemu-devel] [PATCH v27 05/33] QemuOpts: change opt->name|str from (const char *) to (char *) Chunyan Liu
2014-05-07  9:54 ` [Qemu-devel] [PATCH v27 06/33] QemuOpts: move qemu_opt_del ahead for later calling Chunyan Liu
2014-05-07  9:54 ` [Qemu-devel] [PATCH v27 07/33] QemuOpts: add qemu_opt_get_*_del functions for replace work Chunyan Liu
2014-05-07  9:54 ` [Qemu-devel] [PATCH v27 08/33] QemuOpts: add qemu_opts_print_help to replace print_option_help Chunyan Liu
2014-05-07  9:54 ` [Qemu-devel] [PATCH v27 09/33] QemuOpts: add conversion between QEMUOptionParameter to QemuOpts Chunyan Liu
2014-05-07  9:54 ` [Qemu-devel] [PATCH v27 10/33] QemuOpts: add qemu_opts_append to replace append_option_parameters Chunyan Liu
2014-05-07  9:54 ` [Qemu-devel] [PATCH v27 11/33] QemuOpts: check NULL input for qemu_opts_del Chunyan Liu
2014-05-07  9:54 ` [Qemu-devel] [PATCH v27 12/33] change block layer to support both QemuOpts and QEMUOptionParamter Chunyan Liu
2014-05-07  9:54 ` [Qemu-devel] [PATCH v27 13/33] vvfat.c: handle cross_driver's create_options and create_opts Chunyan Liu
2014-05-07  9:54 ` [Qemu-devel] [PATCH v27 14/33] cow.c: replace QEMUOptionParameter with QemuOpts Chunyan Liu
2014-05-07  9:54 ` [Qemu-devel] [PATCH v27 15/33] gluster.c: " Chunyan Liu
2014-05-07  9:54 ` [Qemu-devel] [PATCH v27 16/33] iscsi.c: " Chunyan Liu
2014-05-07 10:17 ` [Qemu-devel] [PATCH v27 00/33] " Chun Yan Liu
2014-05-14  8:58 ` Chun Yan Liu
  -- strict thread matches above, loose matches on Subject: below --
2014-05-07  9:58 Chunyan Liu
2014-05-07  9:58 ` [Qemu-devel] [PATCH v27 01/33] QemuOpts: move find_desc_by_name ahead for later calling Chunyan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1399456476-10786-2-git-send-email-cyliu@suse.com \
    --to=cyliu@suse.com \
    --cc=l@dorileo.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).