From: Chunyan Liu <cyliu@suse.com>
To: qemu-devel@nongnu.org
Cc: l@dorileo.org, stefanha@redhat.com
Subject: [Qemu-devel] [PATCH v27 04/33] qapi: output def_value_str when query command line options
Date: Wed, 7 May 2014 17:54:07 +0800 [thread overview]
Message-ID: <1399456476-10786-5-git-send-email-cyliu@suse.com> (raw)
In-Reply-To: <1399456476-10786-1-git-send-email-cyliu@suse.com>
Change qapi interfaces to output the newly added def_value_str when querying
command line options.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Leandro Dorileo <l@dorileo.org>
Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Signed-off-by: Chunyan Liu <cyliu@suse.com>
---
qapi-schema.json | 5 ++++-
qmp-commands.hx | 2 ++
util/qemu-config.c | 4 ++++
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/qapi-schema.json b/qapi-schema.json
index 0b00427..880829d 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -4088,12 +4088,15 @@
#
# @help: #optional human readable text string, not suitable for parsing.
#
+# @default: #optional default value string (since 2.1)
+#
# Since 1.5
##
{ 'type': 'CommandLineParameterInfo',
'data': { 'name': 'str',
'type': 'CommandLineParameterType',
- '*help': 'str' } }
+ '*help': 'str',
+ '*default': 'str' } }
##
# @CommandLineOptionInfo:
diff --git a/qmp-commands.hx b/qmp-commands.hx
index ed3ab92..1271332 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -2895,6 +2895,8 @@ Each array entry contains the following:
or 'size')
- "help": human readable description of the parameter
(json-string, optional)
+ - "default": default value string for the parameter
+ (json-string, optional)
Example:
diff --git a/util/qemu-config.c b/util/qemu-config.c
index f4e4f38..ba375c0 100644
--- a/util/qemu-config.c
+++ b/util/qemu-config.c
@@ -82,6 +82,10 @@ static CommandLineParameterInfoList *query_option_descs(const QemuOptDesc *desc)
info->has_help = true;
info->help = g_strdup(desc[i].help);
}
+ if (desc[i].def_value_str) {
+ info->has_q_default = true;
+ info->q_default = g_strdup(desc[i].def_value_str);
+ }
entry = g_malloc0(sizeof(*entry));
entry->value = info;
--
1.7.12.4
next prev parent reply other threads:[~2014-05-07 9:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 9:54 [Qemu-devel] [PATCH v27 00/33] replace QEMUOptionParameter with QemuOpts Chunyan Liu
2014-05-07 9:54 ` [Qemu-devel] [PATCH v27 01/33] QemuOpts: move find_desc_by_name ahead for later calling Chunyan Liu
2014-05-07 9:54 ` [Qemu-devel] [PATCH v27 02/33] QemuOpts: repurpose qemu_opts_print to replace print_option_parameters Chunyan Liu
2014-05-07 9:54 ` [Qemu-devel] [PATCH v27 03/33] QemuOpts: add def_value_str to QemuOptDesc Chunyan Liu
2014-05-07 9:54 ` Chunyan Liu [this message]
2014-05-07 9:54 ` [Qemu-devel] [PATCH v27 05/33] QemuOpts: change opt->name|str from (const char *) to (char *) Chunyan Liu
2014-05-07 9:54 ` [Qemu-devel] [PATCH v27 06/33] QemuOpts: move qemu_opt_del ahead for later calling Chunyan Liu
2014-05-07 9:54 ` [Qemu-devel] [PATCH v27 07/33] QemuOpts: add qemu_opt_get_*_del functions for replace work Chunyan Liu
2014-05-07 9:54 ` [Qemu-devel] [PATCH v27 08/33] QemuOpts: add qemu_opts_print_help to replace print_option_help Chunyan Liu
2014-05-07 9:54 ` [Qemu-devel] [PATCH v27 09/33] QemuOpts: add conversion between QEMUOptionParameter to QemuOpts Chunyan Liu
2014-05-07 9:54 ` [Qemu-devel] [PATCH v27 10/33] QemuOpts: add qemu_opts_append to replace append_option_parameters Chunyan Liu
2014-05-07 9:54 ` [Qemu-devel] [PATCH v27 11/33] QemuOpts: check NULL input for qemu_opts_del Chunyan Liu
2014-05-07 9:54 ` [Qemu-devel] [PATCH v27 12/33] change block layer to support both QemuOpts and QEMUOptionParamter Chunyan Liu
2014-05-07 9:54 ` [Qemu-devel] [PATCH v27 13/33] vvfat.c: handle cross_driver's create_options and create_opts Chunyan Liu
2014-05-07 9:54 ` [Qemu-devel] [PATCH v27 14/33] cow.c: replace QEMUOptionParameter with QemuOpts Chunyan Liu
2014-05-07 9:54 ` [Qemu-devel] [PATCH v27 15/33] gluster.c: " Chunyan Liu
2014-05-07 9:54 ` [Qemu-devel] [PATCH v27 16/33] iscsi.c: " Chunyan Liu
2014-05-07 10:17 ` [Qemu-devel] [PATCH v27 00/33] " Chun Yan Liu
2014-05-14 8:58 ` Chun Yan Liu
-- strict thread matches above, loose matches on Subject: below --
2014-05-07 9:58 Chunyan Liu
2014-05-07 9:58 ` [Qemu-devel] [PATCH v27 04/33] qapi: output def_value_str when query command line options Chunyan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399456476-10786-5-git-send-email-cyliu@suse.com \
--to=cyliu@suse.com \
--cc=l@dorileo.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).