From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Anthony Liguori" <aliguori@amazon.com>,
=?UTF-8?q?Herv=C3=A9=20Poussineau?= <hpoussin@reactos.org>,
"Alex Bligh" <alex@alex.org.uk>,
"Paolo Bonzini" <pbonzini@redhat.com>,
=?UTF-8?q?Andreas=20F=C3=A4rber?= <afaerber@suse.de>
Subject: [Qemu-devel] [PULL 04/10] i8259: don't abort when trying to use level sensitive irqs
Date: Wed, 7 May 2014 18:41:29 +0300 [thread overview]
Message-ID: <1399477052-18612-5-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1399477052-18612-1-git-send-email-mst@redhat.com>
From: Hervé Poussineau <hpoussin@reactos.org>
This is a guest-triggerable error, as seen when using Xenix 2.3.4.
Replace hw_error by LOG_UNIMPL, so that guests can continue.
With this patch, I can install and use Xenix 2.3.4a without any problem.
I can also start installation of Xenix 2.3.4q, but it fails due to not
finding an hard disk.
Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/intc/i8259.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c
index c6f248b..a069d04 100644
--- a/hw/intc/i8259.c
+++ b/hw/intc/i8259.c
@@ -265,7 +265,8 @@ static void pic_ioport_write(void *opaque, hwaddr addr64,
s->init4 = val & 1;
s->single_mode = val & 2;
if (val & 0x08) {
- hw_error("level sensitive irq not supported");
+ qemu_log_mask(LOG_UNIMP,
+ "i8259: level sensitive irq not supported\n");
}
} else if (val & 0x08) {
if (val & 0x04) {
--
MST
next prev parent reply other threads:[~2014-05-07 15:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 15:37 [Qemu-devel] [PULL 00/10] pc,net,MAINTAINERS,build updates Michael S. Tsirkin
2014-05-07 15:37 ` [Qemu-devel] [PULL 01/10] acpi/pcihp.c: Rewrite acpi_pcihp_get_bsel using object_property_get_int Michael S. Tsirkin
2014-05-07 15:41 ` [Qemu-devel] [PULL 02/10] acpi-build: properly decrement objects' reference counters Michael S. Tsirkin
2014-05-07 15:41 ` [Qemu-devel] [PULL 03/10] acpi: fix tables for no-hpet configuration Michael S. Tsirkin
2014-05-07 15:41 ` Michael S. Tsirkin [this message]
2014-05-07 15:41 ` [Qemu-devel] [PULL 05/10] pc: add compat_props placeholder for 2.0 machine type Michael S. Tsirkin
2014-05-07 15:41 ` [Qemu-devel] [PULL 06/10] apic: use emulated lapic version 0x14 on pc machines >= 2.1 Michael S. Tsirkin
2014-05-07 15:41 ` [Qemu-devel] [PULL 07/10] smbus: allow returning an error from reads Michael S. Tsirkin
2014-05-07 15:41 ` [Qemu-devel] [PULL 08/10] smbus: return -1 if nothing found at the given address Michael S. Tsirkin
2014-05-07 15:42 ` [Qemu-devel] [PULL 09/10] pm_smbus: correctly report unclaimed cycles Michael S. Tsirkin
2014-05-07 15:42 ` [Qemu-devel] [PULL 10/10] MAINTAINERS: addresses for responsible disclosure Michael S. Tsirkin
2014-05-07 16:13 ` [Qemu-devel] [PULL 00/10] pc,net,MAINTAINERS,build updates Peter Maydell
2014-05-07 16:17 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399477052-18612-5-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=afaerber@suse.de \
--cc=alex@alex.org.uk \
--cc=aliguori@amazon.com \
--cc=hpoussin@reactos.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).