From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56461) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wi4Y4-0005fu-RP for qemu-devel@nongnu.org; Wed, 07 May 2014 12:18:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wi4Xz-0001uo-Qv for qemu-devel@nongnu.org; Wed, 07 May 2014 12:18:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6236) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wi4Xz-0001uk-Ix for qemu-devel@nongnu.org; Wed, 07 May 2014 12:18:19 -0400 Date: Wed, 7 May 2014 19:17:01 +0300 From: "Michael S. Tsirkin" Message-ID: <1399479367-31336-5-git-send-email-mst@redhat.com> References: <1399479367-31336-1-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1399479367-31336-1-git-send-email-mst@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL v2 04/11] i8259: don't abort when trying to use level sensitive irqs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Maydell , Anthony Liguori , =?us-ascii?B?PT9VVEYtOD9xP0hlcnY9QzM9QTk9MjBQb3Vzc2luZWF1Pz0=?= , Alex Bligh , Paolo Bonzini , =?us-ascii?B?PT9VVEYtOD9xP0FuZHJlYXM9MjBGPUMzPUE0cmJlcj89?= From: Herv=E9 Poussineau This is a guest-triggerable error, as seen when using Xenix 2.3.4. Replace hw_error by LOG_UNIMPL, so that guests can continue. With this patch, I can install and use Xenix 2.3.4a without any problem. I can also start installation of Xenix 2.3.4q, but it fails due to not finding an hard disk. Signed-off-by: Herv=E9 Poussineau Acked-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/intc/i8259.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c index c6f248b..a069d04 100644 --- a/hw/intc/i8259.c +++ b/hw/intc/i8259.c @@ -265,7 +265,8 @@ static void pic_ioport_write(void *opaque, hwaddr add= r64, s->init4 =3D val & 1; s->single_mode =3D val & 2; if (val & 0x08) { - hw_error("level sensitive irq not supported"); + qemu_log_mask(LOG_UNIMP, + "i8259: level sensitive irq not supported\= n"); } } else if (val & 0x08) { if (val & 0x04) { --=20 MST