From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Peter Crosthwaite" <peter.crosthwaite@xilinx.com>,
=?UTF-8?q?Andreas=20F=C3=A4rber?= <afaerber@suse.de>,
"Anthony Liguori" <aliguori@amazon.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [Qemu-devel] [PULL v2 07/11] smbus: allow returning an error from reads
Date: Wed, 7 May 2014 19:17:13 +0300 [thread overview]
Message-ID: <1399479367-31336-8-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1399479367-31336-1-git-send-email-mst@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Andreas Färber <afaerber@suse.de>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
include/hw/i2c/smbus.h | 6 +++---
hw/i2c/smbus.c | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/include/hw/i2c/smbus.h b/include/hw/i2c/smbus.h
index 63f0cc4..285d3b5 100644
--- a/include/hw/i2c/smbus.h
+++ b/include/hw/i2c/smbus.h
@@ -67,11 +67,11 @@ struct SMBusDevice {
/* Master device commands. */
void smbus_quick_command(I2CBus *bus, uint8_t addr, int read);
-uint8_t smbus_receive_byte(I2CBus *bus, uint8_t addr);
+int smbus_receive_byte(I2CBus *bus, uint8_t addr);
void smbus_send_byte(I2CBus *bus, uint8_t addr, uint8_t data);
-uint8_t smbus_read_byte(I2CBus *bus, uint8_t addr, uint8_t command);
+int smbus_read_byte(I2CBus *bus, uint8_t addr, uint8_t command);
void smbus_write_byte(I2CBus *bus, uint8_t addr, uint8_t command, uint8_t data);
-uint16_t smbus_read_word(I2CBus *bus, uint8_t addr, uint8_t command);
+int smbus_read_word(I2CBus *bus, uint8_t addr, uint8_t command);
void smbus_write_word(I2CBus *bus, uint8_t addr, uint8_t command, uint16_t data);
int smbus_read_block(I2CBus *bus, uint8_t addr, uint8_t command, uint8_t *data);
void smbus_write_block(I2CBus *bus, uint8_t addr, uint8_t command, uint8_t *data,
diff --git a/hw/i2c/smbus.c b/hw/i2c/smbus.c
index 3febf3c..190f08e 100644
--- a/hw/i2c/smbus.c
+++ b/hw/i2c/smbus.c
@@ -214,7 +214,7 @@ void smbus_quick_command(I2CBus *bus, uint8_t addr, int read)
i2c_end_transfer(bus);
}
-uint8_t smbus_receive_byte(I2CBus *bus, uint8_t addr)
+int smbus_receive_byte(I2CBus *bus, uint8_t addr)
{
uint8_t data;
@@ -232,7 +232,7 @@ void smbus_send_byte(I2CBus *bus, uint8_t addr, uint8_t data)
i2c_end_transfer(bus);
}
-uint8_t smbus_read_byte(I2CBus *bus, uint8_t addr, uint8_t command)
+int smbus_read_byte(I2CBus *bus, uint8_t addr, uint8_t command)
{
uint8_t data;
i2c_start_transfer(bus, addr, 0);
@@ -252,7 +252,7 @@ void smbus_write_byte(I2CBus *bus, uint8_t addr, uint8_t command, uint8_t data)
i2c_end_transfer(bus);
}
-uint16_t smbus_read_word(I2CBus *bus, uint8_t addr, uint8_t command)
+int smbus_read_word(I2CBus *bus, uint8_t addr, uint8_t command)
{
uint16_t data;
i2c_start_transfer(bus, addr, 0);
--
MST
next prev parent reply other threads:[~2014-05-07 16:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 16:16 [Qemu-devel] [PULL v2 00/11] pc,net,MAINTAINERS,build updates Michael S. Tsirkin
2014-05-07 16:16 ` [Qemu-devel] [PULL v2 01/11] acpi/pcihp.c: Rewrite acpi_pcihp_get_bsel using object_property_get_int Michael S. Tsirkin
2014-05-07 16:16 ` [Qemu-devel] [PULL v2 02/11] acpi-build: properly decrement objects' reference counters Michael S. Tsirkin
2014-05-07 16:16 ` [Qemu-devel] [PULL v2 03/11] acpi: fix tables for no-hpet configuration Michael S. Tsirkin
2014-05-07 16:17 ` [Qemu-devel] [PULL v2 04/11] i8259: don't abort when trying to use level sensitive irqs Michael S. Tsirkin
2014-05-07 16:17 ` [Qemu-devel] [PULL v2 05/11] pc: add compat_props placeholder for 2.0 machine type Michael S. Tsirkin
2014-05-07 16:17 ` [Qemu-devel] [PULL v2 06/11] apic: use emulated lapic version 0x14 on pc machines >= 2.1 Michael S. Tsirkin
2014-05-07 16:17 ` Michael S. Tsirkin [this message]
2014-05-07 16:17 ` [Qemu-devel] [PULL v2 08/11] smbus: return -1 if nothing found at the given address Michael S. Tsirkin
2014-05-07 16:17 ` [Qemu-devel] [PULL v2 09/11] pm_smbus: correctly report unclaimed cycles Michael S. Tsirkin
2014-05-07 16:17 ` [Qemu-devel] [PULL v2 10/11] MAINTAINERS: addresses for responsible disclosure Michael S. Tsirkin
2014-05-07 16:17 ` [Qemu-devel] [PULL v2 11/11] configure: make source tree build more robust Michael S. Tsirkin
2014-05-07 17:14 ` [Qemu-devel] [PULL v2 00/11] pc,net,MAINTAINERS,build updates Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399479367-31336-8-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@amazon.com \
--cc=pbonzini@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).