From: Hani Benhabiles <kroosec@gmail.com>
To: qemu-devel@nongnu.org
Cc: kraxel@redhat.com, lcapitulino@redhat.com
Subject: [Qemu-devel] [PATCH 3/6] monitor: Add chardev-add backend argument completion.
Date: Wed, 7 May 2014 23:41:29 +0100 [thread overview]
Message-ID: <1399502492-6188-4-git-send-email-kroosec@gmail.com> (raw)
In-Reply-To: <1399502492-6188-1-git-send-email-kroosec@gmail.com>
Signed-off-by: Hani Benhabiles <hani@linux.com>
---
hmp-commands.hx | 1 +
hmp.h | 1 +
monitor.c | 23 +++++++++++++++++++++++
3 files changed, 25 insertions(+)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index ba88e2a..93fa534 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -1623,6 +1623,7 @@ ETEXI
.params = "args",
.help = "add chardev",
.mhandler.cmd = hmp_chardev_add,
+ .command_completion = chardev_add_completion,
},
STEXI
diff --git a/hmp.h b/hmp.h
index affc2b6..f8e16a8 100644
--- a/hmp.h
+++ b/hmp.h
@@ -99,5 +99,6 @@ void device_add_completion(ReadLineState *rs, int nb_args, const char *str);
void device_del_completion(ReadLineState *rs, int nb_args, const char *str);
void sendkey_completion(ReadLineState *rs, int nb_args, const char *str);
void chardev_remove_completion(ReadLineState *rs, int nb_args, const char *str);
+void chardev_add_completion(ReadLineState *rs, int nb_args, const char *str);
#endif
diff --git a/monitor.c b/monitor.c
index 6316a29..dacff19 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4252,6 +4252,29 @@ static const char *next_arg_type(const char *typestr)
return (p != NULL ? ++p : typestr);
}
+void chardev_add_completion(ReadLineState *rs, int nb_args, const char *str)
+{
+ size_t len;
+ ChardevBackendInfoList *list, *start;
+
+ if (nb_args != 2) {
+ return;
+ }
+ len = strlen(str);
+ readline_set_completion_index(rs, len);
+
+ start = list = qmp_query_chardev_backends(NULL);
+ while (list) {
+ const char *chr_name = list->value->name;
+
+ if (!strncmp(chr_name, str, len)) {
+ readline_add_completion(rs, chr_name);
+ }
+ list = list->next;
+ }
+ qapi_free_ChardevBackendInfoList(start);
+}
+
void device_add_completion(ReadLineState *rs, int nb_args, const char *str)
{
GSList *list, *elt;
--
1.8.3.2
next prev parent reply other threads:[~2014-05-07 22:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 22:41 [Qemu-devel] [PATCH 0/6] Miscellaneous command completion patches Hani Benhabiles
2014-05-07 22:41 ` [Qemu-devel] [PATCH 1/6] monitor: Convert sendkey to use command_completion Hani Benhabiles
2014-05-07 22:41 ` [Qemu-devel] [PATCH 2/6] monitor: Add chardev-remove command completion Hani Benhabiles
2014-05-07 22:41 ` Hani Benhabiles [this message]
2014-05-07 22:41 ` [Qemu-devel] [PATCH 4/6] monitor: Add set_link arguments completion Hani Benhabiles
2014-05-07 22:41 ` [Qemu-devel] [PATCH 5/6] monitor: Add netdev_add type argument completion Hani Benhabiles
2014-05-07 22:41 ` [Qemu-devel] [PATCH 6/6] monitor: Add netdev_del id " Hani Benhabiles
2014-05-08 8:16 ` [Qemu-devel] [PATCH 0/6] Miscellaneous command completion patches Gerd Hoffmann
2014-05-15 18:33 ` Luiz Capitulino
2014-05-15 19:42 ` Hani Benhabiles
2014-05-15 20:10 ` Luiz Capitulino
2014-05-15 20:56 ` Hani Benhabiles
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399502492-6188-4-git-send-email-kroosec@gmail.com \
--to=kroosec@gmail.com \
--cc=kraxel@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).