From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59908) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WiAXB-0005H6-J5 for qemu-devel@nongnu.org; Wed, 07 May 2014 18:41:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WiAX5-000346-Fp for qemu-devel@nongnu.org; Wed, 07 May 2014 18:41:53 -0400 Received: from mail-wi0-x230.google.com ([2a00:1450:400c:c05::230]:46130) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WiAX5-00033j-9R for qemu-devel@nongnu.org; Wed, 07 May 2014 18:41:47 -0400 Received: by mail-wi0-f176.google.com with SMTP id n15so7165031wiw.9 for ; Wed, 07 May 2014 15:41:46 -0700 (PDT) From: Hani Benhabiles Date: Wed, 7 May 2014 23:41:30 +0100 Message-Id: <1399502492-6188-5-git-send-email-kroosec@gmail.com> In-Reply-To: <1399502492-6188-1-git-send-email-kroosec@gmail.com> References: <1399502492-6188-1-git-send-email-kroosec@gmail.com> Subject: [Qemu-devel] [PATCH 4/6] monitor: Add set_link arguments completion. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kraxel@redhat.com, lcapitulino@redhat.com Make it possible to query all net clients without specifying an ID when calling qemu_find_net_clients_except(). This also adds the add_completion_option() function which is to be used for other commands completions as well. Signed-off-by: Hani Benhabiles --- hmp-commands.hx | 1 + hmp.h | 1 + monitor.c | 34 ++++++++++++++++++++++++++++++++++ net/net.c | 2 +- 4 files changed, 37 insertions(+), 1 deletion(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 93fa534..3e7b29c 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -1340,6 +1340,7 @@ ETEXI .params = "name on|off", .help = "change the link status of a network adapter", .mhandler.cmd = hmp_set_link, + .command_completion = set_link_completion, }, STEXI diff --git a/hmp.h b/hmp.h index f8e16a8..91c9c85 100644 --- a/hmp.h +++ b/hmp.h @@ -100,5 +100,6 @@ void device_del_completion(ReadLineState *rs, int nb_args, const char *str); void sendkey_completion(ReadLineState *rs, int nb_args, const char *str); void chardev_remove_completion(ReadLineState *rs, int nb_args, const char *str); void chardev_add_completion(ReadLineState *rs, int nb_args, const char *str); +void set_link_completion(ReadLineState *rs, int nb_args, const char *str); #endif diff --git a/monitor.c b/monitor.c index dacff19..5ead568 100644 --- a/monitor.c +++ b/monitor.c @@ -4252,6 +4252,17 @@ static const char *next_arg_type(const char *typestr) return (p != NULL ? ++p : typestr); } +static void add_completion_option(ReadLineState *rs, const char *str, + const char *option) +{ + if (!str || !option) { + return; + } + if (!strncmp(option, str, strlen(str))) { + readline_add_completion(rs, option); + } +} + void chardev_add_completion(ReadLineState *rs, int nb_args, const char *str) { size_t len; @@ -4427,6 +4438,29 @@ void sendkey_completion(ReadLineState *rs, int nb_args, const char *str) } } +void set_link_completion(ReadLineState *rs, int nb_args, const char *str) +{ + size_t len; + + len = strlen(str); + readline_set_completion_index(rs, len); + if (nb_args == 2) { + NetClientState *ncs[255]; + int count, i; + count = qemu_find_net_clients_except(NULL, ncs, + NET_CLIENT_OPTIONS_KIND_NONE, 255); + for (i = 0; i < count; i++) { + const char *name = ncs[i]->name; + if (!strncmp(str, name, len)) { + readline_add_completion(rs, name); + } + } + } else if (nb_args == 3) { + add_completion_option(rs, str, "on"); + add_completion_option(rs, str, "off"); + } +} + static void monitor_find_completion_by_table(Monitor *mon, const mon_cmd_t *cmd_table, char **args, diff --git a/net/net.c b/net/net.c index 9db4dba..0ff2e40 100644 --- a/net/net.c +++ b/net/net.c @@ -633,7 +633,7 @@ int qemu_find_net_clients_except(const char *id, NetClientState **ncs, if (nc->info->type == type) { continue; } - if (!strcmp(nc->name, id)) { + if (!id || !strcmp(nc->name, id)) { if (ret < max) { ncs[ret] = nc; } -- 1.8.3.2