From: Hani Benhabiles <kroosec@gmail.com>
To: qemu-devel@nongnu.org
Cc: kraxel@redhat.com, lcapitulino@redhat.com
Subject: [Qemu-devel] [PATCH 6/6] monitor: Add netdev_del id argument completion.
Date: Wed, 7 May 2014 23:41:32 +0100 [thread overview]
Message-ID: <1399502492-6188-7-git-send-email-kroosec@gmail.com> (raw)
In-Reply-To: <1399502492-6188-1-git-send-email-kroosec@gmail.com>
Signed-off-by: Hani Benhabiles <hani@linux.com>
---
hmp-commands.hx | 1 +
hmp.h | 1 +
monitor.c | 26 ++++++++++++++++++++++++++
3 files changed, 28 insertions(+)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index a7f9b2f..2e462c0 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -1252,6 +1252,7 @@ ETEXI
.params = "id",
.help = "remove host network device",
.mhandler.cmd = hmp_netdev_del,
+ .command_completion = netdev_del_completion,
},
STEXI
diff --git a/hmp.h b/hmp.h
index bcecd0d..aba59e9 100644
--- a/hmp.h
+++ b/hmp.h
@@ -102,5 +102,6 @@ void chardev_remove_completion(ReadLineState *rs, int nb_args, const char *str);
void chardev_add_completion(ReadLineState *rs, int nb_args, const char *str);
void set_link_completion(ReadLineState *rs, int nb_args, const char *str);
void netdev_add_completion(ReadLineState *rs, int nb_args, const char *str);
+void netdev_del_completion(ReadLineState *rs, int nb_args, const char *str);
#endif
diff --git a/monitor.c b/monitor.c
index a4c429c..7f68549 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4476,6 +4476,32 @@ void set_link_completion(ReadLineState *rs, int nb_args, const char *str)
}
}
+void netdev_del_completion(ReadLineState *rs, int nb_args, const char *str)
+{
+ int len, count, i;
+ NetClientState *ncs[255];
+
+ if (nb_args != 2) {
+ return;
+ }
+
+ len = strlen(str);
+ readline_set_completion_index(rs, len);
+ count = qemu_find_net_clients_except(NULL, ncs, NET_CLIENT_OPTIONS_KIND_NIC,
+ 255);
+ for (i = 0; i < count; i++) {
+ QemuOpts *opts;
+ const char *name = ncs[i]->name;
+ if (strncmp(str, name, len)) {
+ continue;
+ }
+ opts = qemu_opts_find(qemu_find_opts_err("netdev", NULL), name);
+ if (opts) {
+ readline_add_completion(rs, name);
+ }
+ }
+}
+
static void monitor_find_completion_by_table(Monitor *mon,
const mon_cmd_t *cmd_table,
char **args,
--
1.8.3.2
next prev parent reply other threads:[~2014-05-07 22:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 22:41 [Qemu-devel] [PATCH 0/6] Miscellaneous command completion patches Hani Benhabiles
2014-05-07 22:41 ` [Qemu-devel] [PATCH 1/6] monitor: Convert sendkey to use command_completion Hani Benhabiles
2014-05-07 22:41 ` [Qemu-devel] [PATCH 2/6] monitor: Add chardev-remove command completion Hani Benhabiles
2014-05-07 22:41 ` [Qemu-devel] [PATCH 3/6] monitor: Add chardev-add backend argument completion Hani Benhabiles
2014-05-07 22:41 ` [Qemu-devel] [PATCH 4/6] monitor: Add set_link arguments completion Hani Benhabiles
2014-05-07 22:41 ` [Qemu-devel] [PATCH 5/6] monitor: Add netdev_add type argument completion Hani Benhabiles
2014-05-07 22:41 ` Hani Benhabiles [this message]
2014-05-08 8:16 ` [Qemu-devel] [PATCH 0/6] Miscellaneous command completion patches Gerd Hoffmann
2014-05-15 18:33 ` Luiz Capitulino
2014-05-15 19:42 ` Hani Benhabiles
2014-05-15 20:10 ` Luiz Capitulino
2014-05-15 20:56 ` Hani Benhabiles
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399502492-6188-7-git-send-email-kroosec@gmail.com \
--to=kroosec@gmail.com \
--cc=kraxel@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).