qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: qemu-devel@nongnu.org
Cc: peter.crosthwaite@xilinx.com, linux@roeck-us.net
Subject: [Qemu-devel] [PATCH v1 3/5] xilinx_intc: Fix writes into MER register
Date: Thu,  8 May 2014 11:35:06 +1000	[thread overview]
Message-ID: <1399512908-23925-4-git-send-email-edgar.iglesias@gmail.com> (raw)
In-Reply-To: <1399512908-23925-1-git-send-email-edgar.iglesias@gmail.com>

From: Guenter Roeck <linux@roeck-us.net>

The MER register only has two valid bits. This is now used by
the linux kernel to auto-detect endianness, and causes Linux 3.15-rc1
and later to hang when run under qemu-microblaze. Mask valid bits before
writing the register to solve the problem.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>
[Edgar: Untabified]
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>
---
 hw/intc/xilinx_intc.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/hw/intc/xilinx_intc.c b/hw/intc/xilinx_intc.c
index 1b228ff..c3682f1 100644
--- a/hw/intc/xilinx_intc.c
+++ b/hw/intc/xilinx_intc.c
@@ -121,6 +121,9 @@ pic_write(void *opaque, hwaddr addr,
         case R_CIE:
             p->regs[R_IER] &= ~value; /* Atomic clear ie.  */
             break;
+        case R_MER:
+            p->regs[R_MER] = value & 0x3;
+            break;
         case R_ISR:
             if ((p->regs[R_MER] & 2)) {
                 break;
-- 
1.8.3.2

  parent reply	other threads:[~2014-05-08  1:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-08  1:35 [Qemu-devel] [PATCH v1 0/5] MicroBlaze queue Edgar E. Iglesias
2014-05-08  1:35 ` [Qemu-devel] [PATCH v1 1/5] microblaze: Support loading of u-boot initrd images Edgar E. Iglesias
2014-05-08  2:33   ` Peter Crosthwaite
2014-05-08  1:35 ` [Qemu-devel] [PATCH v1 2/5] microblaze: Respect the reset vector Edgar E. Iglesias
2014-05-08  2:34   ` Peter Crosthwaite
2014-05-08  1:35 ` Edgar E. Iglesias [this message]
2014-05-08  2:39   ` [Qemu-devel] [PATCH v1 3/5] xilinx_intc: Fix writes into MER register Peter Crosthwaite
2014-05-08  1:35 ` [Qemu-devel] [PATCH v1 4/5] xilinx_timer: Fix writes into TCSR register Edgar E. Iglesias
2014-05-08  2:45   ` Peter Crosthwaite
2014-05-08  3:42     ` Edgar E. Iglesias
2014-05-08  1:35 ` [Qemu-devel] [PATCH v1 5/5] microblaze: boot: Don't hack the elf entry point Edgar E. Iglesias

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1399512908-23925-4-git-send-email-edgar.iglesias@gmail.com \
    --to=edgar.iglesias@gmail.com \
    --cc=linux@roeck-us.net \
    --cc=peter.crosthwaite@xilinx.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).