From: Gerd Hoffmann <kraxel@redhat.com>
To: Hani Benhabiles <kroosec@gmail.com>
Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/6] Miscellaneous command completion patches
Date: Thu, 08 May 2014 10:16:18 +0200 [thread overview]
Message-ID: <1399536978.28932.22.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <1399502492-6188-1-git-send-email-kroosec@gmail.com>
On Mi, 2014-05-07 at 23:41 +0100, Hani Benhabiles wrote:
> Compared to v1:
> * Dropped patch 02/07 for help completion conversion.
> * Nothing else changed. 04,05 and 06 are R-b by Stefan.
>
> Hani Benhabiles (6):
> monitor: Convert sendkey to use command_completion.
> monitor: Add chardev-remove command completion.
> monitor: Add chardev-add backend argument completion.
Don't know much about readline completion internals, but the way the
valid choices are figured in these three patches looks sane to me.
cheers,
Gerd
next prev parent reply other threads:[~2014-05-08 8:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 22:41 [Qemu-devel] [PATCH 0/6] Miscellaneous command completion patches Hani Benhabiles
2014-05-07 22:41 ` [Qemu-devel] [PATCH 1/6] monitor: Convert sendkey to use command_completion Hani Benhabiles
2014-05-07 22:41 ` [Qemu-devel] [PATCH 2/6] monitor: Add chardev-remove command completion Hani Benhabiles
2014-05-07 22:41 ` [Qemu-devel] [PATCH 3/6] monitor: Add chardev-add backend argument completion Hani Benhabiles
2014-05-07 22:41 ` [Qemu-devel] [PATCH 4/6] monitor: Add set_link arguments completion Hani Benhabiles
2014-05-07 22:41 ` [Qemu-devel] [PATCH 5/6] monitor: Add netdev_add type argument completion Hani Benhabiles
2014-05-07 22:41 ` [Qemu-devel] [PATCH 6/6] monitor: Add netdev_del id " Hani Benhabiles
2014-05-08 8:16 ` Gerd Hoffmann [this message]
2014-05-15 18:33 ` [Qemu-devel] [PATCH 0/6] Miscellaneous command completion patches Luiz Capitulino
2014-05-15 19:42 ` Hani Benhabiles
2014-05-15 20:10 ` Luiz Capitulino
2014-05-15 20:56 ` Hani Benhabiles
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399536978.28932.22.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=kroosec@gmail.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).