From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40080) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WiJVG-0001uC-Jl for qemu-devel@nongnu.org; Thu, 08 May 2014 04:16:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WiJVA-0002MD-Ds for qemu-devel@nongnu.org; Thu, 08 May 2014 04:16:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31666) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WiJVA-0002M0-6d for qemu-devel@nongnu.org; Thu, 08 May 2014 04:16:24 -0400 Message-ID: <1399536978.28932.22.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Thu, 08 May 2014 10:16:18 +0200 In-Reply-To: <1399502492-6188-1-git-send-email-kroosec@gmail.com> References: <1399502492-6188-1-git-send-email-kroosec@gmail.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/6] Miscellaneous command completion patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hani Benhabiles Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com On Mi, 2014-05-07 at 23:41 +0100, Hani Benhabiles wrote: > Compared to v1: > * Dropped patch 02/07 for help completion conversion. > * Nothing else changed. 04,05 and 06 are R-b by Stefan. > > Hani Benhabiles (6): > monitor: Convert sendkey to use command_completion. > monitor: Add chardev-remove command completion. > monitor: Add chardev-add backend argument completion. Don't know much about readline completion internals, but the way the valid choices are figured in these three patches looks sane to me. cheers, Gerd