From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48038) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WiK3c-0001i9-K8 for qemu-devel@nongnu.org; Thu, 08 May 2014 04:52:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WiK3W-0006Yr-FG for qemu-devel@nongnu.org; Thu, 08 May 2014 04:52:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32697) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WiK3W-0006Xg-7o for qemu-devel@nongnu.org; Thu, 08 May 2014 04:51:54 -0400 From: Gerd Hoffmann Date: Thu, 8 May 2014 10:51:43 +0200 Message-Id: <1399539104-20468-2-git-send-email-kraxel@redhat.com> In-Reply-To: <1399539104-20468-1-git-send-email-kraxel@redhat.com> References: <1399539104-20468-1-git-send-email-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL 1/2] spice: fix "info spice" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann , Anthony Liguori In case no listening address was specified, "info spice" reports "0.0.0.0" as address. Which is incorrect in case spice is listening on ipv6. Replace it by a wildcard "*" to indicate it is not limited to a specific address. Note: Being more specific is not possible without extending the spice-server api. The socket is handled by spice-server not qemu, so qemu can't easily figure the actual socket address. Reported-by: David Ja=C5=A1a Signed-off-by: Gerd Hoffmann --- ui/spice-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index 4cce3b3..6825579 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -532,7 +532,7 @@ SpiceInfo *qmp_query_spice(Error **errp) info->auth =3D g_strdup(auth); =20 info->has_host =3D true; - info->host =3D g_strdup(addr ? addr : "0.0.0.0"); + info->host =3D g_strdup(addr ? addr : "*"); =20 info->has_compiled_version =3D true; major =3D (SPICE_SERVER_VERSION & 0xff0000) >> 16; --=20 1.8.3.1