* [Qemu-devel] [PATCH] build: add support for $@-cflags to all compiler rules
@ 2014-05-08 12:46 Paolo Bonzini
2014-05-08 12:56 ` Michael Tokarev
2014-05-08 13:04 ` Fam Zheng
0 siblings, 2 replies; 4+ messages in thread
From: Paolo Bonzini @ 2014-05-08 12:46 UTC (permalink / raw)
To: qemu-devel; +Cc: mjt
This is needed in order to use per-object flags variables.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
rules.mak | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/rules.mak b/rules.mak
index 7038576..c0c3d86 100644
--- a/rules.mak
+++ b/rules.mak
@@ -45,7 +45,7 @@ LINK = $(call quiet-command,$(LINKPROG) $(QEMU_CFLAGS) $(CFLAGS) $(LDFLAGS) -o $
else
LIBTOOL += $(if $(V),,--quiet)
%.lo: %.c
- $(call quiet-command,$(LIBTOOL) --mode=compile --tag=CC $(CC) $(QEMU_INCLUDES) $(QEMU_CFLAGS) $(QEMU_DGFLAGS) $(CFLAGS) -c -o $@ $<," lt CC $@")
+ $(call quiet-command,$(LIBTOOL) --mode=compile --tag=CC $(CC) $(QEMU_INCLUDES) $(QEMU_CFLAGS) $(QEMU_DGFLAGS) $(CFLAGS) $($*.o-cflags) -c -o $@ $<," lt CC $@")
%.lo: %.rc
$(call quiet-command,$(LIBTOOL) --mode=compile --tag=RC $(WINDRES) -I. -o $@ $<,"lt RC $(TARGET_DIR)$@")
%.lo: %.dtrace
@@ -67,13 +67,13 @@ endif
$(call quiet-command,$(AS) $(ASFLAGS) -o $@ $<," AS $(TARGET_DIR)$@")
%.o: %.cc
- $(call quiet-command,$(CXX) $(QEMU_INCLUDES) $(QEMU_CXXFLAGS) $(QEMU_DGFLAGS) $(CFLAGS) -c -o $@ $<," CXX $(TARGET_DIR)$@")
+ $(call quiet-command,$(CXX) $(QEMU_INCLUDES) $(QEMU_CXXFLAGS) $(QEMU_DGFLAGS) $(CFLAGS) $($@-cflags) -c -o $@ $<," CXX $(TARGET_DIR)$@")
%.o: %.cpp
- $(call quiet-command,$(CXX) $(QEMU_INCLUDES) $(QEMU_CXXFLAGS) $(QEMU_DGFLAGS) $(CFLAGS) -c -o $@ $<," CXX $(TARGET_DIR)$@")
+ $(call quiet-command,$(CXX) $(QEMU_INCLUDES) $(QEMU_CXXFLAGS) $(QEMU_DGFLAGS) $(CFLAGS) $($@-cflags) -c -o $@ $<," CXX $(TARGET_DIR)$@")
%.o: %.m
- $(call quiet-command,$(OBJCC) $(QEMU_INCLUDES) $(QEMU_CFLAGS) $(QEMU_DGFLAGS) $(CFLAGS) -c -o $@ $<," OBJC $(TARGET_DIR)$@")
+ $(call quiet-command,$(OBJCC) $(QEMU_INCLUDES) $(QEMU_CFLAGS) $(QEMU_DGFLAGS) $(CFLAGS) $($@-cflags) -c -o $@ $<," OBJC $(TARGET_DIR)$@")
%.o: %.dtrace
$(call quiet-command,dtrace -o $@ -G -s $<, " GEN $(TARGET_DIR)$@")
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] build: add support for $@-cflags to all compiler rules
2014-05-08 12:46 [Qemu-devel] [PATCH] build: add support for $@-cflags to all compiler rules Paolo Bonzini
@ 2014-05-08 12:56 ` Michael Tokarev
2014-05-08 13:04 ` Paolo Bonzini
2014-05-08 13:04 ` Fam Zheng
1 sibling, 1 reply; 4+ messages in thread
From: Michael Tokarev @ 2014-05-08 12:56 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel
08.05.2014 16:46, Paolo Bonzini wrote:
> This is needed in order to use per-object flags variables.
Assuming we don't need to have separate -cflags for asm files,
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Thanks,
/mjt
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] build: add support for $@-cflags to all compiler rules
2014-05-08 12:56 ` Michael Tokarev
@ 2014-05-08 13:04 ` Paolo Bonzini
0 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2014-05-08 13:04 UTC (permalink / raw)
To: Michael Tokarev, qemu-devel
Il 08/05/2014 14:56, Michael Tokarev ha scritto:
> 08.05.2014 16:46, Paolo Bonzini wrote:
>> This is needed in order to use per-object flags variables.
>
> Assuming we don't need to have separate -cflags for asm files,
Perhaps those would be better called -asflags.
Thanks for the review, I'll send more fixes to use -cflags in libcacard.
Paolo
> Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
>
> Thanks,
>
> /mjt
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] build: add support for $@-cflags to all compiler rules
2014-05-08 12:46 [Qemu-devel] [PATCH] build: add support for $@-cflags to all compiler rules Paolo Bonzini
2014-05-08 12:56 ` Michael Tokarev
@ 2014-05-08 13:04 ` Fam Zheng
1 sibling, 0 replies; 4+ messages in thread
From: Fam Zheng @ 2014-05-08 13:04 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: mjt, qemu-devel
On Thu, 05/08 14:46, Paolo Bonzini wrote:
> This is needed in order to use per-object flags variables.
My assignment but fell between the cracks. Thanks, looks good,
Reviewed-by: Fam Zheng <famz@redhat.com>
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> rules.mak | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/rules.mak b/rules.mak
> index 7038576..c0c3d86 100644
> --- a/rules.mak
> +++ b/rules.mak
> @@ -45,7 +45,7 @@ LINK = $(call quiet-command,$(LINKPROG) $(QEMU_CFLAGS) $(CFLAGS) $(LDFLAGS) -o $
> else
> LIBTOOL += $(if $(V),,--quiet)
> %.lo: %.c
> - $(call quiet-command,$(LIBTOOL) --mode=compile --tag=CC $(CC) $(QEMU_INCLUDES) $(QEMU_CFLAGS) $(QEMU_DGFLAGS) $(CFLAGS) -c -o $@ $<," lt CC $@")
> + $(call quiet-command,$(LIBTOOL) --mode=compile --tag=CC $(CC) $(QEMU_INCLUDES) $(QEMU_CFLAGS) $(QEMU_DGFLAGS) $(CFLAGS) $($*.o-cflags) -c -o $@ $<," lt CC $@")
> %.lo: %.rc
> $(call quiet-command,$(LIBTOOL) --mode=compile --tag=RC $(WINDRES) -I. -o $@ $<,"lt RC $(TARGET_DIR)$@")
> %.lo: %.dtrace
> @@ -67,13 +67,13 @@ endif
> $(call quiet-command,$(AS) $(ASFLAGS) -o $@ $<," AS $(TARGET_DIR)$@")
>
> %.o: %.cc
> - $(call quiet-command,$(CXX) $(QEMU_INCLUDES) $(QEMU_CXXFLAGS) $(QEMU_DGFLAGS) $(CFLAGS) -c -o $@ $<," CXX $(TARGET_DIR)$@")
> + $(call quiet-command,$(CXX) $(QEMU_INCLUDES) $(QEMU_CXXFLAGS) $(QEMU_DGFLAGS) $(CFLAGS) $($@-cflags) -c -o $@ $<," CXX $(TARGET_DIR)$@")
>
> %.o: %.cpp
> - $(call quiet-command,$(CXX) $(QEMU_INCLUDES) $(QEMU_CXXFLAGS) $(QEMU_DGFLAGS) $(CFLAGS) -c -o $@ $<," CXX $(TARGET_DIR)$@")
> + $(call quiet-command,$(CXX) $(QEMU_INCLUDES) $(QEMU_CXXFLAGS) $(QEMU_DGFLAGS) $(CFLAGS) $($@-cflags) -c -o $@ $<," CXX $(TARGET_DIR)$@")
>
> %.o: %.m
> - $(call quiet-command,$(OBJCC) $(QEMU_INCLUDES) $(QEMU_CFLAGS) $(QEMU_DGFLAGS) $(CFLAGS) -c -o $@ $<," OBJC $(TARGET_DIR)$@")
> + $(call quiet-command,$(OBJCC) $(QEMU_INCLUDES) $(QEMU_CFLAGS) $(QEMU_DGFLAGS) $(CFLAGS) $($@-cflags) -c -o $@ $<," OBJC $(TARGET_DIR)$@")
>
> %.o: %.dtrace
> $(call quiet-command,dtrace -o $@ -G -s $<, " GEN $(TARGET_DIR)$@")
> --
> 1.8.3.1
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-05-08 13:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-08 12:46 [Qemu-devel] [PATCH] build: add support for $@-cflags to all compiler rules Paolo Bonzini
2014-05-08 12:56 ` Michael Tokarev
2014-05-08 13:04 ` Paolo Bonzini
2014-05-08 13:04 ` Fam Zheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).